jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/362227 )
Change subject: Performance: update ReadingListData.listContainsTitle
......................................................................
Performance: update ReadingListData.listContainsTitle
Rather than getting all page rows containing the list and re-iterating
over them, just get the page row for the page we're insterested in and
check the list keys.
Change-Id: I8e25404430b9e493ddf2f2f92888d30304930094
---
M app/src/main/java/org/wikipedia/readinglist/ReadingListData.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Dbrant: Looks good to me, approved
jenkins-bot: Verified
diff --git a/app/src/main/java/org/wikipedia/readinglist/ReadingListData.java
b/app/src/main/java/org/wikipedia/readinglist/ReadingListData.java
index c4c4052..c6f970e 100644
--- a/app/src/main/java/org/wikipedia/readinglist/ReadingListData.java
+++ b/app/src/main/java/org/wikipedia/readinglist/ReadingListData.java
@@ -199,11 +199,11 @@
}
private synchronized boolean listContainsTitle(@NonNull String listKey,
@NonNull String key) {
- Cursor cursor = ReadingListPageDao.instance().pages(listKey);
+ Cursor cursor = ReadingListPageDao.instance().page(key);
try {
- while (cursor.moveToNext()) {
+ if (cursor.moveToFirst()) {
ReadingListPage page = ReadingListPage.fromCursor(cursor);
- if (page.key().equals(key)) {
+ if (page.listKeys().contains(listKey)) {
return true;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/362227
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e25404430b9e493ddf2f2f92888d30304930094
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
