jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/362176 )
Change subject: Use constraint type item ID in remaining error messages
......................................................................
Use constraint type item ID in remaining error messages
All error messages that are constructed in the checkers themselves (for
error messages in ConstraintParameterParser, see I336821ecf3) now also
render the constraint type item ID to a localized link. A few checkers
need to get a ConstraintParameterRenderer for that.
Bug: T167399
Change-Id: I8cd68ad203bbc874ec313be393098bc3069175dc
---
M includes/ConstraintCheck/Checker/CommonsLinkChecker.php
M includes/ConstraintCheck/Checker/DiffWithinRangeChecker.php
M includes/ConstraintCheck/Checker/FormatChecker.php
M includes/ConstraintCheck/Checker/InverseChecker.php
M includes/ConstraintCheck/Checker/RangeChecker.php
M includes/ConstraintCheck/Checker/SymmetricChecker.php
M includes/ConstraintCheck/Checker/TargetRequiredClaimChecker.php
M includes/ConstraintCheck/Checker/UniqueValueChecker.php
M includes/ConstraintReportFactory.php
M tests/phpunit/Checker/CommonsLinkChecker/CommonsLinkCheckerTest.php
M tests/phpunit/Checker/FormatChecker/FormatCheckerTest.php
M tests/phpunit/Checker/ValueCountChecker/UniqueValueCheckerTest.php
12 files changed, 105 insertions(+), 27 deletions(-)
Approvals:
Jonas Kress (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/ConstraintCheck/Checker/CommonsLinkChecker.php
b/includes/ConstraintCheck/Checker/CommonsLinkChecker.php
index b10d4ac..d84762c 100644
--- a/includes/ConstraintCheck/Checker/CommonsLinkChecker.php
+++ b/includes/ConstraintCheck/Checker/CommonsLinkChecker.php
@@ -12,6 +12,7 @@
use
WikibaseQuality\ConstraintReport\ConstraintCheck\Helper\ConstraintParameterParser;
use WikibaseQuality\ConstraintReport\ConstraintCheck\Result\CheckResult;
use WikibaseQuality\ConstraintReport\Constraint;
+use WikibaseQuality\ConstraintReport\ConstraintParameterRenderer;
use Wikibase\DataModel\Statement\Statement;
/**
@@ -27,19 +28,27 @@
private $constraintParameterParser;
/**
+ * @var ConstraintParameterRenderer
+ */
+ private $constraintParameterRenderer;
+
+ /**
* @var TitleParser
*/
private $titleParser;
/**
* @param ConstraintParameterParser $constraintParameterParser
+ * @param ConstraintParameterRenderer $constraintParameterRenderer
* @param TitleParser $titleParser
*/
public function __construct(
ConstraintParameterParser $constraintParameterParser,
+ ConstraintParameterRenderer $constraintParameterRenderer,
TitleParser $titleParser
) {
$this->constraintParameterParser = $constraintParameterParser;
+ $this->constraintParameterRenderer =
$constraintParameterRenderer;
$this->titleParser = $titleParser;
}
@@ -65,7 +74,9 @@
* $mainSnak must be PropertyValueSnak, neither
PropertySomeValueSnak nor PropertyNoValueSnak is allowed
*/
if ( !$mainSnak instanceof PropertyValueSnak ) {
- $message = wfMessage(
"wbqc-violation-message-value-needed" )->params(
$constraint->getConstraintTypeName() )->escaped();
+ $message = wfMessage(
"wbqc-violation-message-value-needed" )
+ ->rawParams(
$this->constraintParameterRenderer->formatItemId(
$constraint->getConstraintTypeItemId(),
ConstraintParameterRenderer::ROLE_CONSTRAINT_TYPE_ITEM ) )
+ ->escaped();
return new CheckResult( $entity->getId(), $statement,
$constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
}
@@ -77,7 +88,12 @@
* parameter $namespace can be null, works for commons
galleries
*/
if ( $dataValue->getType() !== 'string' ) {
- $message = wfMessage(
"wbqc-violation-message-value-needed-of-type" )->params(
$constraint->getConstraintTypeName(), 'string' )->escaped();
+ $message = wfMessage(
"wbqc-violation-message-value-needed-of-type" )
+ ->rawParams(
+
$this->constraintParameterRenderer->formatItemId(
$constraint->getConstraintTypeItemId(),
ConstraintParameterRenderer::ROLE_CONSTRAINT_TYPE_ITEM ),
+ wfMessage(
'datatypes-type-string' )->escaped()
+ )
+ ->escaped();
return new CheckResult( $entity->getId(), $statement,
$constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
}
diff --git a/includes/ConstraintCheck/Checker/DiffWithinRangeChecker.php
b/includes/ConstraintCheck/Checker/DiffWithinRangeChecker.php
index d702a25..9597437 100644
--- a/includes/ConstraintCheck/Checker/DiffWithinRangeChecker.php
+++ b/includes/ConstraintCheck/Checker/DiffWithinRangeChecker.php
@@ -70,7 +70,9 @@
* $mainSnak must be PropertyValueSnak, neither
PropertySomeValueSnak nor PropertyNoValueSnak is allowed
*/
if ( !$mainSnak instanceof PropertyValueSnak ) {
- $message = wfMessage(
"wbqc-violation-message-value-needed" )->params(
$constraint->getConstraintTypeName() )->escaped();
+ $message = wfMessage(
"wbqc-violation-message-value-needed" )
+ ->rawParams(
$this->constraintParameterRenderer->formatItemId(
$constraint->getConstraintTypeItemId(),
ConstraintParameterRenderer::ROLE_CONSTRAINT_TYPE_ITEM ) )
+ ->escaped();
return new CheckResult( $entity->getId(), $statement,
$constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
}
diff --git a/includes/ConstraintCheck/Checker/FormatChecker.php
b/includes/ConstraintCheck/Checker/FormatChecker.php
index 849a85c..caa66a4 100644
--- a/includes/ConstraintCheck/Checker/FormatChecker.php
+++ b/includes/ConstraintCheck/Checker/FormatChecker.php
@@ -9,6 +9,7 @@
use WikibaseQuality\ConstraintReport\ConstraintCheck\ConstraintChecker;
use
WikibaseQuality\ConstraintReport\ConstraintCheck\Helper\ConstraintParameterParser;
use WikibaseQuality\ConstraintReport\ConstraintCheck\Result\CheckResult;
+use WikibaseQuality\ConstraintReport\ConstraintParameterRenderer;
use Wikibase\DataModel\Statement\Statement;
/**
@@ -24,10 +25,20 @@
private $constraintParameterParser;
/**
- * @param ConstraintParameterParser $constraintParameterParser
+ * @var ConstraintParameterRenderer
*/
- public function __construct( $constraintParameterParser ) {
+ private $onstraintParameterRenderer;
+
+ /**
+ * @param ConstraintParameterParser $constraintParameterParser
+ * @param ConstraintParameterRenderer $constraintParameterRenderer
+ */
+ public function __construct(
+ ConstraintParameterParser $constraintParameterParser,
+ ConstraintParameterRenderer $constraintParameterRenderer
+ ) {
$this->constraintParameterParser = $constraintParameterParser;
+ $this->constraintParameterRenderer =
$constraintParameterRenderer;
}
/**
@@ -53,7 +64,9 @@
* $mainSnak must be PropertyValueSnak, neither
PropertySomeValueSnak nor PropertyNoValueSnak is allowed
*/
if ( !$mainSnak instanceof PropertyValueSnak ) {
- $message = wfMessage(
"wbqc-violation-message-value-needed" )->params(
$constraint->getConstraintTypeName() )->escaped();
+ $message = wfMessage(
"wbqc-violation-message-value-needed" )
+ ->rawParams(
$this->constraintParameterRenderer->formatItemId(
$constraint->getConstraintTypeItemId(),
ConstraintParameterRenderer::ROLE_CONSTRAINT_TYPE_ITEM ) )
+ ->escaped();
return new CheckResult( $entity->getId(), $statement,
$constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
}
@@ -65,11 +78,19 @@
*/
$type = $dataValue->getType();
if ( $type !== 'string' && $type !== 'monolingualtext' ) {
- $message = wfMessage(
"wbqc-violation-message-value-needed-of-types-2" )->params(
$constraint->getConstraintTypeName(), 'string', 'monolingualtext' )->escaped();
+ $message = wfMessage(
"wbqc-violation-message-value-needed-of-type" )
+ ->rawParams(
+
$this->constraintParameterRenderer->formatItemId(
$constraint->getConstraintTypeItemId(),
ConstraintParameterRenderer::ROLE_CONSTRAINT_TYPE_ITEM ),
+ wfMessage(
'datatypes-type-string' )->escaped(),
+ wfMessage(
'datatypes-type-monolingualtext' )->escaped()
+ )
+ ->escaped();
return new CheckResult( $entity->getId(), $statement,
$constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
}
- $message = wfMessage( 'wbqc-violation-message-security-reason'
)->params( $constraint->getConstraintTypeName(), 'string' )->escaped();
+ $message = wfMessage( "wbqc-violation-message-security-reason" )
+ ->rawParams(
$this->constraintParameterRenderer->formatItemId(
$constraint->getConstraintTypeItemId(),
ConstraintParameterRenderer::ROLE_CONSTRAINT_TYPE_ITEM ) )
+ ->escaped();
return new CheckResult( $entity->getId(), $statement,
$constraint, $parameters, CheckResult::STATUS_TODO, $message );
}
diff --git a/includes/ConstraintCheck/Checker/InverseChecker.php
b/includes/ConstraintCheck/Checker/InverseChecker.php
index 1fd30f0..b8b9b5c 100644
--- a/includes/ConstraintCheck/Checker/InverseChecker.php
+++ b/includes/ConstraintCheck/Checker/InverseChecker.php
@@ -83,7 +83,9 @@
* $mainSnak must be PropertyValueSnak, neither
PropertySomeValueSnak nor PropertyNoValueSnak is allowed
*/
if ( !$mainSnak instanceof PropertyValueSnak ) {
- $message = wfMessage(
"wbqc-violation-message-value-needed" )->params(
$constraint->getConstraintTypeName() )->escaped();
+ $message = wfMessage(
"wbqc-violation-message-value-needed" )
+ ->rawParams(
$this->constraintParameterRenderer->formatItemId(
$constraint->getConstraintTypeItemId(),
ConstraintParameterRenderer::ROLE_CONSTRAINT_TYPE_ITEM ) )
+ ->escaped();
return new CheckResult( $entity->getId(), $statement,
$constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
}
@@ -94,7 +96,12 @@
* type of $dataValue for properties with 'Inverse'
constraint has to be 'wikibase-entityid'
*/
if ( $dataValue->getType() !== 'wikibase-entityid' ) {
- $message = wfMessage(
"wbqc-violation-message-value-needed-of-type" )->params(
$constraint->getConstraintTypeName(), 'wikibase-entityid' )->escaped();
+ $message = wfMessage(
"wbqc-violation-message-value-needed-of-type" )
+ ->rawParams(
+
$this->constraintParameterRenderer->formatItemId(
$constraint->getConstraintTypeItemId(),
ConstraintParameterRenderer::ROLE_CONSTRAINT_TYPE_ITEM ),
+ 'wikibase-entityid' // TODO is
there a message for this type so we can localize it?
+ )
+ ->escaped();
return new CheckResult( $entity->getId(), $statement,
$constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
}
/** @var EntityIdValue $dataValue */
diff --git a/includes/ConstraintCheck/Checker/RangeChecker.php
b/includes/ConstraintCheck/Checker/RangeChecker.php
index f3df06b..12758c3 100644
--- a/includes/ConstraintCheck/Checker/RangeChecker.php
+++ b/includes/ConstraintCheck/Checker/RangeChecker.php
@@ -70,7 +70,9 @@
* $mainSnak must be PropertyValueSnak, neither
PropertySomeValueSnak nor PropertyNoValueSnak is allowed
*/
if ( !$mainSnak instanceof PropertyValueSnak ) {
- $message = wfMessage(
"wbqc-violation-message-value-needed" )->params(
$constraint->getConstraintTypeName() )->escaped();
+ $message = wfMessage(
"wbqc-violation-message-value-needed" )
+ ->rawParams(
$this->constraintParameterRenderer->formatItemId(
$constraint->getConstraintTypeItemId(),
ConstraintParameterRenderer::ROLE_CONSTRAINT_TYPE_ITEM ) )
+ ->escaped();
return new CheckResult( $entity->getId(), $statement,
$constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
}
diff --git a/includes/ConstraintCheck/Checker/SymmetricChecker.php
b/includes/ConstraintCheck/Checker/SymmetricChecker.php
index bec0319..3b6be78 100644
--- a/includes/ConstraintCheck/Checker/SymmetricChecker.php
+++ b/includes/ConstraintCheck/Checker/SymmetricChecker.php
@@ -71,7 +71,9 @@
* $mainSnak must be PropertyValueSnak, neither
PropertySomeValueSnak nor PropertyNoValueSnak is allowed
*/
if ( !$mainSnak instanceof PropertyValueSnak ) {
- $message = wfMessage(
"wbqc-violation-message-value-needed" )->params(
$constraint->getConstraintTypeName() )->escaped();
+ $message = wfMessage(
"wbqc-violation-message-value-needed" )
+ ->rawParams(
$this->constraintParameterRenderer->formatItemId(
$constraint->getConstraintTypeItemId(),
ConstraintParameterRenderer::ROLE_CONSTRAINT_TYPE_ITEM ) )
+ ->escaped();
return new CheckResult( $entity->getId(), $statement,
$constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
}
@@ -82,7 +84,12 @@
* type of $dataValue for properties with 'Symmetric'
constraint has to be 'wikibase-entityid'
*/
if ( $dataValue->getType() !== 'wikibase-entityid' ) {
- $message = wfMessage(
"wbqc-violation-message-value-needed-of-type" )->params(
$constraint->getConstraintTypeName(), 'wikibase-entityid' )->escaped();
+ $message = wfMessage(
"wbqc-violation-message-value-needed-of-type" )
+ ->rawParams(
+
$this->constraintParameterRenderer->formatItemId(
$constraint->getConstraintTypeItemId(),
ConstraintParameterRenderer::ROLE_CONSTRAINT_TYPE_ITEM ),
+ 'wikibase-entityid' // TODO is
there a message for this type so we can localize it?
+ )
+ ->escaped();
return new CheckResult( $entity->getId(), $statement,
$constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
}
/** @var EntityIdValue $dataValue */
diff --git a/includes/ConstraintCheck/Checker/TargetRequiredClaimChecker.php
b/includes/ConstraintCheck/Checker/TargetRequiredClaimChecker.php
index 959ae76..516a381 100644
--- a/includes/ConstraintCheck/Checker/TargetRequiredClaimChecker.php
+++ b/includes/ConstraintCheck/Checker/TargetRequiredClaimChecker.php
@@ -86,7 +86,9 @@
* $mainSnak must be PropertyValueSnak, neither
PropertySomeValueSnak nor PropertyNoValueSnak is allowed
*/
if ( !$mainSnak instanceof PropertyValueSnak ) {
- $message = wfMessage(
"wbqc-violation-message-value-needed" )->params(
$constraint->getConstraintTypeName() )->escaped();
+ $message = wfMessage(
"wbqc-violation-message-value-needed" )
+ ->rawParams(
$this->constraintParameterRenderer->formatItemId(
$constraint->getConstraintTypeItemId(),
ConstraintParameterRenderer::ROLE_CONSTRAINT_TYPE_ITEM ) )
+ ->escaped();
return new CheckResult( $entity->getId(), $statement,
$constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
}
@@ -97,7 +99,12 @@
* type of $dataValue for properties with 'Target required
claim' constraint has to be 'wikibase-entityid'
*/
if ( $dataValue->getType() !== 'wikibase-entityid' ) {
- $message = wfMessage(
"wbqc-violation-message-value-needed-of-type" )->params(
$constraint->getConstraintTypeName(), 'wikibase-entityid' )->escaped();
+ $message = wfMessage(
"wbqc-violation-message-value-needed-of-type" )
+ ->rawParams(
+
$this->constraintParameterRenderer->formatItemId(
$constraint->getConstraintTypeItemId(),
ConstraintParameterRenderer::ROLE_CONSTRAINT_TYPE_ITEM ),
+ 'wikibase-entityid' // TODO is there a
message for this type so we can localize it?
+ )
+ ->escaped();
return new CheckResult( $entity->getId(), $statement,
$constraint, $parameters, CheckResult::STATUS_VIOLATION, $message );
}
/** @var EntityIdValue $dataValue */
diff --git a/includes/ConstraintCheck/Checker/UniqueValueChecker.php
b/includes/ConstraintCheck/Checker/UniqueValueChecker.php
index 64b0632..b8238a7 100644
--- a/includes/ConstraintCheck/Checker/UniqueValueChecker.php
+++ b/includes/ConstraintCheck/Checker/UniqueValueChecker.php
@@ -9,6 +9,7 @@
use WikibaseQuality\ConstraintReport\ConstraintCheck\Helper\SparqlHelper;
use
WikibaseQuality\ConstraintReport\ConstraintCheck\Helper\SparqlHelperException;
use WikibaseQuality\ConstraintReport\ConstraintCheck\Result\CheckResult;
+use WikibaseQuality\ConstraintReport\ConstraintParameterRenderer;
use Wikibase\DataModel\Statement\Statement;
/**
@@ -19,14 +20,24 @@
class UniqueValueChecker implements ConstraintChecker {
/**
+ * @var ConstraintParameterRenderer
+ */
+ private $constraintParameterRenderer;
+
+ /**
* @var SparqlHelper|null
*/
private $sparqlHelper;
/**
+ * @param ConstraintParameterRenderer $constraintParameterRenderer used
in error messages
* @param SparqlHelper|null $sparqlHelper Helper to run SPARQL queries,
or null if SPARQL is not available.
*/
- public function __construct( SparqlHelper $sparqlHelper = null ) {
+ public function __construct(
+ ConstraintParameterRenderer $constraintParameterRenderer,
+ SparqlHelper $sparqlHelper = null
+ ) {
+ $this->constraintParameterRenderer =
$constraintParameterRenderer;
$this->sparqlHelper = $sparqlHelper;
}
@@ -57,8 +68,8 @@
}
} else {
$status = CheckResult::STATUS_TODO;
- $message = wfMessage(
'wbqc-violation-message-not-yet-implemented' )
- ->params(
$constraint->getConstraintTypeName() )
+ $message = wfMessage(
"wbqc-violation-message-not-yet-implemented" )
+ ->rawParams(
$this->constraintParameterRenderer->formatItemId(
$constraint->getConstraintTypeItemId(),
ConstraintParameterRenderer::ROLE_CONSTRAINT_TYPE_ITEM ) )
->escaped();
}
diff --git a/includes/ConstraintReportFactory.php
b/includes/ConstraintReportFactory.php
index 7c52512..dbd6c87 100644
--- a/includes/ConstraintReportFactory.php
+++ b/includes/ConstraintReportFactory.php
@@ -219,9 +219,9 @@
'Value type' => new ValueTypeChecker(
$this->lookup, $this->constraintParameterParser, $typeCheckerHelper,
$this->config ),
'Single value' => new SingleValueChecker(),
'Multi value' => new MultiValueChecker(),
- 'Unique value' => new UniqueValueChecker(
$sparqlHelper ),
- 'Format' => new FormatChecker(
$this->constraintParameterParser ),
- 'Commons link' => new CommonsLinkChecker(
$this->constraintParameterParser, $this->titleParser ),
+ 'Unique value' => new UniqueValueChecker(
$this->constraintParameterRenderer, $sparqlHelper ),
+ 'Format' => new FormatChecker(
$this->constraintParameterParser, $this->constraintParameterRenderer ),
+ 'Commons link' => new CommonsLinkChecker(
$this->constraintParameterParser, $this->constraintParameterRenderer,
$this->titleParser ),
'One of' => new OneOfChecker(
$this->constraintParameterParser, $this->constraintParameterRenderer ),
];
$this->constraintCheckerMap += [
diff --git
a/tests/phpunit/Checker/CommonsLinkChecker/CommonsLinkCheckerTest.php
b/tests/phpunit/Checker/CommonsLinkChecker/CommonsLinkCheckerTest.php
index 6c2e91e..f8a99e6 100644
--- a/tests/phpunit/Checker/CommonsLinkChecker/CommonsLinkCheckerTest.php
+++ b/tests/phpunit/Checker/CommonsLinkChecker/CommonsLinkCheckerTest.php
@@ -41,7 +41,11 @@
protected function setUp() {
parent::setUp();
- $this->commonsLinkChecker = new CommonsLinkChecker(
$this->getConstraintParameterParser(), $this->getTitleParserMock() );
+ $this->commonsLinkChecker = new CommonsLinkChecker(
+ $this->getConstraintParameterParser(),
+ $this->getConstraintParameterRenderer(),
+ $this->getTitleParserMock()
+ );
$this->tablesUsed[] = 'page';
}
diff --git a/tests/phpunit/Checker/FormatChecker/FormatCheckerTest.php
b/tests/phpunit/Checker/FormatChecker/FormatCheckerTest.php
index 071e9b9..4770feb 100644
--- a/tests/phpunit/Checker/FormatChecker/FormatCheckerTest.php
+++ b/tests/phpunit/Checker/FormatChecker/FormatCheckerTest.php
@@ -38,7 +38,7 @@
protected function setUp() {
parent::setUp();
- $this->formatChecker = new FormatChecker(
$this->getConstraintParameterParser() );
+ $this->formatChecker = new FormatChecker(
$this->getConstraintParameterParser(), $this->getConstraintParameterRenderer()
);
}
public function testFormatConstraintImdb() {
diff --git a/tests/phpunit/Checker/ValueCountChecker/UniqueValueCheckerTest.php
b/tests/phpunit/Checker/ValueCountChecker/UniqueValueCheckerTest.php
index e9c6701..358c731 100644
--- a/tests/phpunit/Checker/ValueCountChecker/UniqueValueCheckerTest.php
+++ b/tests/phpunit/Checker/ValueCountChecker/UniqueValueCheckerTest.php
@@ -9,6 +9,7 @@
use Wikibase\DataModel\Entity\EntityIdValue;
use WikibaseQuality\ConstraintReport\Constraint;
use
WikibaseQuality\ConstraintReport\ConstraintCheck\Checker\UniqueValueChecker;
+use WikibaseQuality\ConstraintReport\Tests\ConstraintParameters;
use WikibaseQuality\ConstraintReport\Tests\ResultAssertions;
use WikibaseQuality\ConstraintReport\Tests\SparqlHelperMock;
use WikibaseQuality\Tests\Helper\JsonFileEntityLookup;
@@ -25,7 +26,7 @@
*/
class UniqueValueCheckerTest extends \PHPUnit_Framework_TestCase {
- use SparqlHelperMock;
+ use ConstraintParameters, SparqlHelperMock;
/**
* @var JsonFileEntityLookup
@@ -57,7 +58,7 @@
$mock = $this->getSparqlHelperMockFindEntities( $statement, [
new ItemId( 'Q42' ) ] );
- $this->checker = new UniqueValueChecker( $mock );
+ $this->checker = new UniqueValueChecker(
$this->getConstraintParameterRenderer(), $mock );
$entity = $this->lookup->getEntity( new ItemId( 'Q6' ) );
@@ -71,7 +72,7 @@
$mock = $this->getSparqlHelperMockFindEntities( $statement, []
);
- $this->checker = new UniqueValueChecker( $mock );
+ $this->checker = new UniqueValueChecker(
$this->getConstraintParameterRenderer(), $mock );
$entity = $this->lookup->getEntity( new ItemId( 'Q1' ) );
@@ -83,7 +84,7 @@
$statement = new Statement( new PropertyValueSnak(
$this->uniquePropertyId, new EntityIdValue( new ItemId( 'Q1' ) ) ) );
$statement->setGuid( "Q1$56e6a474-4431-fb24-cc15-1d580e467559"
);
- $this->checker = new UniqueValueChecker( null );
+ $this->checker = new UniqueValueChecker(
$this->getConstraintParameterRenderer(), null );
$entity = $this->lookup->getEntity( new ItemId( 'Q1' ) );
--
To view, visit https://gerrit.wikimedia.org/r/362176
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8cd68ad203bbc874ec313be393098bc3069175dc
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
