jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/362534 )
Change subject: Allow search suggestions in skins operating in mobile mode ...................................................................... Allow search suggestions in skins operating in mobile mode MobileFrontend silently removes this skin from the page. This is now made explicit and the module can be safely loaded in a mobile environment. This is used by both Timeless which although does not work perfectly on a mobile device it should be easy to fix with additional work. Change-Id: Iedea2872d14430db452cec7e758f20d854778414 Depends-On: Ic36e9792f9217f3fd37bbd1f5c66d894301363f0 --- M resources/Resources.php 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Krinkle: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/Resources.php b/resources/Resources.php index dc05387..317181f 100644 --- a/resources/Resources.php +++ b/resources/Resources.php @@ -238,6 +238,7 @@ 'scripts' => 'resources/lib/jquery/jquery.fullscreen.js', ], 'jquery.getAttrs' => [ + 'targets' => [ 'desktop', 'mobile' ], 'scripts' => 'resources/src/jquery/jquery.getAttrs.js', 'targets' => [ 'desktop', 'mobile' ], ], @@ -325,6 +326,7 @@ 'scripts' => 'resources/lib/jquery/jquery.jStorage.js', ], 'jquery.suggestions' => [ + 'targets' => [ 'desktop', 'mobile' ], 'scripts' => 'resources/src/jquery/jquery.suggestions.js', 'styles' => 'resources/src/jquery/jquery.suggestions.css', 'dependencies' => 'jquery.highlightText', @@ -1182,6 +1184,7 @@ 'styles' => 'resources/src/mediawiki/mediawiki.pager.tablePager.less', ], 'mediawiki.searchSuggest' => [ + 'targets' => [ 'desktop', 'mobile' ], 'scripts' => 'resources/src/mediawiki/mediawiki.searchSuggest.js', 'styles' => 'resources/src/mediawiki/mediawiki.searchSuggest.css', 'messages' => [ -- To view, visit https://gerrit.wikimedia.org/r/362534 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedea2872d14430db452cec7e758f20d854778414 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: Bartosz DziewoĆski <matma....@gmail.com> Gerrit-Reviewer: Isarra <zhoris...@gmail.com> Gerrit-Reviewer: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits