Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/53180
Change subject: Fix broken FormatAction tests.
......................................................................
Fix broken FormatAction tests.
The ve.Surface constructor was recently changed, but the instantiation
in the FormatAction tests was not updated accordingly.
The constructor now requires a ve.init.Target object.
Bug: 39597
Change-Id: Ia4193fbab5c63007ed057009bf9a39f1f9d18fb7
---
M modules/ve/test/actions/ve.FormatAction.test.js
M modules/ve/test/index.php
2 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/80/53180/1
diff --git a/modules/ve/test/actions/ve.FormatAction.test.js
b/modules/ve/test/actions/ve.FormatAction.test.js
index 478c350..81a912d 100644
--- a/modules/ve/test/actions/ve.FormatAction.test.js
+++ b/modules/ve/test/actions/ve.FormatAction.test.js
@@ -11,7 +11,7 @@
function runConverterTest( assert, range, type, attributes, expectedSelection,
expectedData, label ) {
var dom = ve.createDocumentFromHTML( ve.dm.example.isolationHTML ),
- surface = new ve.Surface( $('<div>'), dom ),
+ surface = new ve.Surface( new ve.init.Target( $('<div>') ),
dom ),
formatAction = new ve.FormatAction( surface ),
data = ve.copyArray(
surface.getModel().getDocument().getFullData() );
diff --git a/modules/ve/test/index.php b/modules/ve/test/index.php
index 4cc1a4c..4a45302 100644
--- a/modules/ve/test/index.php
+++ b/modules/ve/test/index.php
@@ -18,10 +18,12 @@
<script src="../../ve/ve.EventEmitter.js"></script>
<script src="../../ve/init/ve.init.js"></script>
<script src="../../ve/init/ve.init.Platform.js"></script>
+ <script src="../../ve/init/ve.init.Target.js"></script>
<script src="../../ve/ve.debug.js"></script>
<!-- Standalone Init -->
<script src="../../ve/init/sa/ve.init.sa.js"></script>
<script src="../../ve/init/sa/ve.init.sa.Platform.js"></script>
+ <script src="../../ve/init/sa/ve.init.sa.Target.js"></script>
<script>
<?php
require( '../../../VisualEditor.i18n.php' );
--
To view, visit https://gerrit.wikimedia.org/r/53180
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4193fbab5c63007ed057009bf9a39f1f9d18fb7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
