Arsfiqball has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/362609 )
Change subject: Show currently selected display type
......................................................................
Show currently selected display type
Create method _setSelectedDisplayType
Remove repetition
Change-Id: I6bf2426c82aaf85a04a04fe9dca4831f6411cf4e
---
M wikibase/queryService/ui/ResultView.js
1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui
refs/changes/09/362609/1
diff --git a/wikibase/queryService/ui/ResultView.js
b/wikibase/queryService/ui/ResultView.js
index d68ce86..92f467a 100644
--- a/wikibase/queryService/ui/ResultView.js
+++ b/wikibase/queryService/ui/ResultView.js
@@ -301,6 +301,8 @@
instance.setSparqlApi( self._sparqlApi );
if ( defaultBrowser === null || defaultBrowser === key
) {
+ self._setSelectedDisplayType(b);
+
defaultBrowser = instance;
}
b.object = instance;
@@ -344,6 +346,8 @@
b.$element.click( function() {
$( this ).closest( '.open'
).removeClass( 'open' );
+ self._setSelectedDisplayType(b);
+
$( '#query-result' ).html( '' );
self._drawResult( b.object );
self._selectedResultBrowser = key;
@@ -380,6 +384,15 @@
/**
* @private
*/
+ SELF.prototype._setSelectedDisplayType = function (b) {
+ $('#display-button').html('<span class="' + b.icon.split( '-',
1 )[0]
+ + ' ' + b.icon + '" aria-hidden="true"></span>'
+ + b.label + '<span class="caret"></span>');
+ }
+
+ /**
+ * @private
+ */
SELF.prototype._track = function( metricName, value, valueType ) {
this._trackingApi.track( TRACKING_NAMESPACE + metricName,
value, valueType );
};
--
To view, visit https://gerrit.wikimedia.org/r/362609
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6bf2426c82aaf85a04a04fe9dca4831f6411cf4e
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Arsfiqball <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
