Mainframe98 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362814 )
Change subject: Adhere to MediaWiki's Coding conventions ...................................................................... Adhere to MediaWiki's Coding conventions Also, the alias file had the wrong name in the top comment. This has been fixed. Change-Id: I784449b345405ebd4eee2d88ebc6affcefd95dbe --- M OrphanedTalkPages.alias.php M README M specials/SpecialOrphanedTalkPages.php 3 files changed, 10 insertions(+), 22 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OrphanedTalkPages refs/changes/14/362814/1 diff --git a/OrphanedTalkPages.alias.php b/OrphanedTalkPages.alias.php index 0a9f0d6..c97a413 100644 --- a/OrphanedTalkPages.alias.php +++ b/OrphanedTalkPages.alias.php @@ -1,11 +1,6 @@ <?php /** - * Aliases for NamespaceManager - * - * Created by PhpStorm. - * User: kswer - * Date: 26-4-2017 - * Time: 16:17 + * Aliases for OrphanedTalkPages */ $specialPageAliases = []; diff --git a/README b/README index ad84cdc..09bd8b2 100644 --- a/README +++ b/README @@ -1,7 +1,5 @@ == About == -Orphaned talk pages adds a new Special page to MediaWiki: Special:OrphanedTalkPages. This special page lists all -talk pages that do not have an accompanying page. The namespaces that are exempt from these checks is the user talk -namespace by default, but this can be configured. +Orphaned talk pages adds a new Special page to MediaWiki: Special:OrphanedTalkPages. This special page lists all talk pages that do not have an accompanying page. The namespaces that are exempt from these checks is the user talk namespace by default, but this can be configured. == Installation instructions == Note: you can also find these on https://www.mediawiki.org/wiki/Extension:OrphanedTalkPages @@ -11,16 +9,11 @@ to your LocalSettings.php file. == Configuration instructions == -This extension introduces two new configuration variables: -$wgOrphanedTalkPagesExemptedNamespaces and $wgOrphanedTalkPagesIgnoreUserTalk +This extension introduces two new configuration variables: $wgOrphanedTalkPagesExemptedNamespaces and $wgOrphanedTalkPagesIgnoreUserTalk. -* $wgOrphanedTalkPagesExemptedNamespaces controls which talk namespaces should be ignored when looking for orphaned -talk pages. This variable is an array of namespace ids and is empty by default. -* $wgOrphanedTalkPagesIgnoreUserTalk determines if the user talk namespace (3, or NS_USER_TALK) should be ignored when -looking for orphaned talk pages. This variable is a boolean and set to true by default. +* $wgOrphanedTalkPagesExemptedNamespaces controls which talk namespaces should be ignored when looking for orphaned talk pages. This variable is an array of namespace ids and is empty by default. +* $wgOrphanedTalkPagesIgnoreUserTalk determines if the user talk namespace (3, or NS_USER_TALK) should be ignored when looking for orphaned talk pages. This variable is a boolean and set to true by default. == Other important notes == -* The query that this special page uses is considered expensive. This means that when $wgMiserMode is enabled, the -results will be served from cache. -* The special page may report talk pages as orphaned when they are not. The most common situation where this happens -is File talk pages when $wgUseInstantCommons or $wgForeignFileRepos is enabled. \ No newline at end of file +* The query that this special page uses is considered expensive. This means that when $wgMiserMode is enabled, the results will be served from cache. +* The special page may report talk pages as orphaned when they are not. The most common situation where this happens is File talk pages when $wgUseInstantCommons or $wgForeignFileRepos is enabled. diff --git a/specials/SpecialOrphanedTalkPages.php b/specials/SpecialOrphanedTalkPages.php index d50ba8e..80f1fc4 100644 --- a/specials/SpecialOrphanedTalkPages.php +++ b/specials/SpecialOrphanedTalkPages.php @@ -40,7 +40,7 @@ } // Check if the User talk namespace should be ignored - if ( $wgOrphanedTalkPagesIgnoreUserTalk === true ) { + if ( $wgOrphanedTalkPagesIgnoreUserTalk ) { $exemptedNamespaces[] = NS_USER_TALK; } @@ -48,12 +48,12 @@ 'tables' => 'page AS p1', 'fields' => [ 'namespace' => 'p1.page_namespace', - 'title' =>'p1.page_title', + 'title' => 'p1.page_title', 'value' => 'page_title' // Sorting ], 'conds' => [ 'p1.page_title NOT LIKE "%/%"', - 'p1.page_namespace % 2 != 0' + 'p1.page_namespace % 2 != 0' ] ]; -- To view, visit https://gerrit.wikimedia.org/r/362814 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I784449b345405ebd4eee2d88ebc6affcefd95dbe Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/OrphanedTalkPages Gerrit-Branch: master Gerrit-Owner: Mainframe98 <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
