jenkins-bot has submitted this change and it was merged.
Change subject: There are too many false positives on deprecated-might due to
homonym methods.
......................................................................
There are too many false positives on deprecated-might due to homonym methods.
The warnings given right now are due to:
125 function WikiPage/Revision/WikiRevision::getText
107 function SpecialPage::exists
26 function Job::pop
22 function Block::clear
22 function Article/EditPage::getContent
18 function WebRequest::getFileSize
18 function Job::insert
9 function ParserOptions/User::getSkin
9 function Block::load
9 function Article::rollback
7 function SpecialPage::getPage
6 function WikiError::isError
4 function SpecialPage::getGroup
4 function DifferenceEngine::setText
3 function LogEventsList::getDisplayTitle
2 function WikiPage/Article::getAutosummary
2 function User::edits
2 function SpecialPage::getFile
1 function WikiPage::replaceSection
1 function WikiPage::preSaveTransform
1 function SpecialPage::name
1 function Block::encodeExpiry
Change-Id: Iff1209f916b119c7c208a0e486c552584af6fb27
---
M check-vars.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Demon: Looks good to me, approved
jenkins-bot: Verified
diff --git a/check-vars.php b/check-vars.php
index 8deb086..656348e 100755
--- a/check-vars.php
+++ b/check-vars.php
@@ -151,7 +151,7 @@
'missing-requires' => true,
'deprecated-calls' => true,
'hidden-deprecated-calls' => false,
- 'deprecated-might' => true,
+ 'deprecated-might' => false, // Too many false positives.
Reenable later.
'poisoned-function' => true,
'error' => true,
# 'help' keyword is reserved!!
@@ -1116,6 +1116,7 @@
'$undoRev' => 'Revision', '$undoafterRev' => 'Revision',
'$msg' => 'Message',
'$stash' => 'UploadStash',
+ '$handler' => 'ContentHandler',
);
static $wellKnownMembers = array(
'db' => 'DatabaseBase', 'dbw' => 'DatabaseBase',
--
To view, visit https://gerrit.wikimedia.org/r/42964
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff1209f916b119c7c208a0e486c552584af6fb27
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/tools/code-utils
Gerrit-Branch: master
Gerrit-Owner: Platonides <[email protected]>
Gerrit-Reviewer: Demon <[email protected]>
Gerrit-Reviewer: Platonides <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
