Tpt has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/362866 )

Change subject: Improves style of Index: pages editing interface
......................................................................

Improves style of Index: pages editing interface

Does some code cleanup too

Change-Id: Ib82bbf0759e34640b53a0f402100a6027b66ca87
---
M includes/index/EditIndexPage.php
M modules/index/ext.proofreadpage.index.css
D modules/index/images/help-question.gif
3 files changed, 10 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage 
refs/changes/66/362866/1

diff --git a/includes/index/EditIndexPage.php b/includes/index/EditIndexPage.php
index cae1488..39221ca 100644
--- a/includes/index/EditIndexPage.php
+++ b/includes/index/EditIndexPage.php
@@ -94,13 +94,11 @@
                        ] );
                }
 
-               if ( !$entry->getHelp() ) {
-                       $fieldLayoutArgs = [
-                               'label' => $entry->getLabel()
-                       ];
-               } else {
-                       $fieldLayoutArgs = [
-                               'label' => $entry->getLabel(),
+               $fieldLayoutArgs = [
+                       'label' => $entry->getLabel()
+               ];
+               if ( $entry->getHelp() ) {
+                       $fieldLayoutArgs += [
                                'help' => $entry->getHelp(),
                                'infusable' => true,
                                'classes' => [ 'prp-fieldLayout-help' ]
diff --git a/modules/index/ext.proofreadpage.index.css 
b/modules/index/ext.proofreadpage.index.css
index 99ff9f3..1bb21aa 100644
--- a/modules/index/ext.proofreadpage.index.css
+++ b/modules/index/ext.proofreadpage.index.css
@@ -1,3 +1,7 @@
 .prp-index-fieldLayout {
-       max-width: 750px;
+       max-width: 60em;
 }
+
+.prp-index-fieldLayout textarea {
+       resize: both;
+}
\ No newline at end of file
diff --git a/modules/index/images/help-question.gif 
b/modules/index/images/help-question.gif
deleted file mode 100644
index b4fc9c5..0000000
--- a/modules/index/images/help-question.gif
+++ /dev/null
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/362866
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib82bbf0759e34640b53a0f402100a6027b66ca87
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Tpt <thoma...@hotmail.fr>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to