Phuedx has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362977 )
Change subject: Hygiene: i13n: Return false over not sampling ...................................................................... Hygiene: i13n: Return false over not sampling Previously, if the browser didn't support the Beacon API, then instrumentation/eventLogging#isEnabled would bucket the user with a sampling rate of 0, which is equivalent to returning false. This change simply does the latter. Additional changes: * Update the documented module names of the instrumentation/eventLogging and statsv modules. Bug: T168847 Change-Id: I7ae5c10da42ca614b5b1a6619f9555e5665344cf --- M resources/dist/index.js M resources/dist/index.js.map M src/instrumentation/eventLogging.js M src/instrumentation/statsv.js M tests/node-qunit/instrumentation/eventLogging.test.js 5 files changed, 8 insertions(+), 18 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups refs/changes/77/362977/1 -- To view, visit https://gerrit.wikimedia.org/r/362977 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7ae5c10da42ca614b5b1a6619f9555e5665344cf Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Phuedx <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
