Santhosh has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/363288 )
Change subject: Let PageTitleWidget inherit from OO.ui.MultilineTextInputWidget
......................................................................
Let PageTitleWidget inherit from OO.ui.MultilineTextInputWidget
Instead of OO.ui.TextInputWidget with multiline configuration,
OO.ui.MultilineTextInputWidget fits our need and also resolves
T169610.
Use readonly property instead of setting the title disabled
for source column.
Bug: T169610
Change-Id: I9e1c9d1f7bcceed2795c9d14fa86eaa6d5960656
---
M modules/ui/styles/widgets/mw.cx.ui.PageTitleWidget.less
M modules/ui/widgets/mw.cx.ui.PageTitleWidget.js
2 files changed, 7 insertions(+), 5 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation
refs/changes/88/363288/1
diff --git a/modules/ui/styles/widgets/mw.cx.ui.PageTitleWidget.less
b/modules/ui/styles/widgets/mw.cx.ui.PageTitleWidget.less
index 9b9d4ed..5f46ebc 100644
--- a/modules/ui/styles/widgets/mw.cx.ui.PageTitleWidget.less
+++ b/modules/ui/styles/widgets/mw.cx.ui.PageTitleWidget.less
@@ -21,6 +21,9 @@
border-color: @gray-light;
box-shadow: inset 0 0 0 1px @gray-light;
}
+ &[readonly] {
+ background-color: @white;
+ }
}
}
}
diff --git a/modules/ui/widgets/mw.cx.ui.PageTitleWidget.js
b/modules/ui/widgets/mw.cx.ui.PageTitleWidget.js
index 1821cb2..a8c35f4 100644
--- a/modules/ui/widgets/mw.cx.ui.PageTitleWidget.js
+++ b/modules/ui/widgets/mw.cx.ui.PageTitleWidget.js
@@ -5,21 +5,20 @@
* It is editable (contenteditable) for translation and readonly for source
page.
* Supports validation of values.
* @class
+ * @extends OO.ui.MultilineTextInputWidget
* @param {Object} [config] Configuration object
*/
mw.cx.widgets.PageTitleWidget = function ( config ) {
// Configuration initialization
config = $.extend( config, {
classes: [ 'cx-pagetitle' ],
- multiline: true,
type: 'text',
- autosize: true,
- disable: !this.editable
+ autosize: true
} );
this.editable = config.editable;
// Parent constructor
mw.cx.widgets.PageTitleWidget.super.call( this, config );
- this.setDisabled( !this.editable );
+ this.setReadOnly( !this.editable );
if ( this.editable ) {
this.setValidation( this.validate );
}
@@ -27,7 +26,7 @@
/* Setup */
-OO.inheritClass( mw.cx.widgets.PageTitleWidget, OO.ui.TextInputWidget );
+OO.inheritClass( mw.cx.widgets.PageTitleWidget, OO.ui.MultilineTextInputWidget
);
mw.cx.widgets.PageTitleWidget.prototype.validate = function ( value ) {
if ( value === undefined || value === null || value === '' ) {
--
To view, visit https://gerrit.wikimedia.org/r/363288
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e1c9d1f7bcceed2795c9d14fa86eaa6d5960656
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
