Phantom42 has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/363358 )
Change subject: Fix Newsletter publisher name not showing up correctly on
Manage page.
......................................................................
Fix Newsletter publisher name not showing up correctly on Manage page.
Bug: T169421
Change-Id: Icd1a1e8c89bee3c3b824a1e264ad0c9c3ea050e2
---
M includes/NewsletterEditPage.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Newsletter
refs/changes/58/363358/1
diff --git a/includes/NewsletterEditPage.php b/includes/NewsletterEditPage.php
index 9910d52..dc04bbe 100644
--- a/includes/NewsletterEditPage.php
+++ b/includes/NewsletterEditPage.php
@@ -127,7 +127,7 @@
'type' => 'usersmultiselect',
'label-message' => 'newsletter-manage-publishers',
'exists' => true,
- 'default' => $publishersNames,
+ 'default' => implode( "\n", $publishersNames ),
];
$fields['Summary'] = [
'type' => 'text',
@@ -371,7 +371,7 @@
$modified = true;
}
- $publisherNames = $data['Publishers'];
+ $publisherNames = explode( "\n", $data['Publishers'] );
// Ask for confirmation before removing all the publishers
if ( !$confirmed && count( $publisherNames ) === 0 ) {
return Status::newFatal(
'newsletter-manage-no-publishers' );
--
To view, visit https://gerrit.wikimedia.org/r/363358
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd1a1e8c89bee3c3b824a1e264ad0c9c3ea050e2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: Phantom42 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
