jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/363362 )
Change subject: Always return something when calling the SpecialPage hook
......................................................................
Always return something when calling the SpecialPage hook
Since the return value of the hook is always checked it is
better to return something everytime. Also added missing doc.
Change-Id: I9a0c43e2b62b76b830624a840ecb05b26900b11b
---
M AdvancedSearch.hooks.php
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Gabriel Birke: Looks good to me, approved
jenkins-bot: Verified
diff --git a/AdvancedSearch.hooks.php b/AdvancedSearch.hooks.php
index 0a24575..0ad3970 100644
--- a/AdvancedSearch.hooks.php
+++ b/AdvancedSearch.hooks.php
@@ -15,6 +15,7 @@
*
* @param SpecialPage $special
* @param string $subpage
+ * @return boolean
*/
public static function onSpecialPageBeforeExecute( SpecialPage
$special, $subpage ) {
/**
@@ -29,6 +30,8 @@
if ( $special->getName() === 'Search' ) {
$special->getOutput()->addModules(
'ext.advancedSearch.init' );
}
+
+ return true;
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/363362
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a0c43e2b62b76b830624a840ecb05b26900b11b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AdvancedSearch
Gerrit-Branch: master
Gerrit-Owner: WMDE-Fisch <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Andrew-WMDE <[email protected]>
Gerrit-Reviewer: Gabriel Birke <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
