jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/363387 )
Change subject: Swap isset() === false to !isset()
......................................................................
Swap isset() === false to !isset()
Remove superfluous === false after isset check too
Change-Id: I9513722b3670e61e177946f7f8fa01ff053bfe73
---
M MediaWiki/Sniffs/WhiteSpace/DisallowEmptyLineFunctionsSniff.php
M MediaWiki/Sniffs/WhiteSpace/SpaceBeforeControlStructureBraceSniff.php
2 files changed, 3 insertions(+), 4 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/MediaWiki/Sniffs/WhiteSpace/DisallowEmptyLineFunctionsSniff.php
b/MediaWiki/Sniffs/WhiteSpace/DisallowEmptyLineFunctionsSniff.php
index a2cf1e7..ec0ea03 100644
--- a/MediaWiki/Sniffs/WhiteSpace/DisallowEmptyLineFunctionsSniff.php
+++ b/MediaWiki/Sniffs/WhiteSpace/DisallowEmptyLineFunctionsSniff.php
@@ -28,8 +28,8 @@
public function process( File $phpcsFile, $stackPtr ) {
$tokens = $phpcsFile->getTokens();
$current = $tokens[$stackPtr];
- if ( isset( $current['scope_opener'] ) === false ||
- isset( $current['parenthesis_closer'] ) === false
+ if ( !isset( $current['scope_opener'] ) ||
+ !isset( $current['parenthesis_closer'] )
) {
return;
}
diff --git
a/MediaWiki/Sniffs/WhiteSpace/SpaceBeforeControlStructureBraceSniff.php
b/MediaWiki/Sniffs/WhiteSpace/SpaceBeforeControlStructureBraceSniff.php
index a7a0a9c..8231a90 100644
--- a/MediaWiki/Sniffs/WhiteSpace/SpaceBeforeControlStructureBraceSniff.php
+++ b/MediaWiki/Sniffs/WhiteSpace/SpaceBeforeControlStructureBraceSniff.php
@@ -37,8 +37,7 @@
*/
public function process( File $phpcsFile, $stackPtr ) {
$tokens = $phpcsFile->getTokens();
- if ( !isset( $tokens[$stackPtr]['scope_opener'] ) ||
- $tokens[$stackPtr]['scope_opener'] === false ) {
+ if ( !isset( $tokens[$stackPtr]['scope_opener'] ) ) {
return;
}
$openBrace = $tokens[$stackPtr]['scope_opener'];
--
To view, visit https://gerrit.wikimedia.org/r/363387
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9513722b3670e61e177946f7f8fa01ff053bfe73
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/tools/codesniffer
Gerrit-Branch: master
Gerrit-Owner: Reedy <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
