Catrope has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/363509 )
Change subject: ChangesListSpecialPage: Don't short-circuit the ChangesList,
instead format zero rows
......................................................................
ChangesListSpecialPage: Don't short-circuit the ChangesList, instead format
zero rows
Short-circuiting the ChangesList causes bugs, because it causes
ChangesList::beginRecentChangesList() to be bypassed. This function
adds important styles and RL modules, especially when enhanced RC is enabled.
Bug: T169835
Change-Id: Ib831c781f4fe91eef787aef3d17e71780be9da51
---
M includes/specialpage/ChangesListSpecialPage.php
1 file changed, 1 insertion(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/09/363509/1
diff --git a/includes/specialpage/ChangesListSpecialPage.php
b/includes/specialpage/ChangesListSpecialPage.php
index 0be0646..cf374de 100644
--- a/includes/specialpage/ChangesListSpecialPage.php
+++ b/includes/specialpage/ChangesListSpecialPage.php
@@ -518,13 +518,7 @@
$rows = $this->getRows();
$opts = $this->getOptions();
if ( $rows === false ) {
- if ( !$this->including() ) {
- $this->doHeader( $opts, 0 );
- $this->outputNoResults();
- $this->getOutput()->setStatusCode( 404 );
- }
-
- return;
+ $rows = new FakeResultWrapper( [] );
}
$batch = new LinkBatch;
--
To view, visit https://gerrit.wikimedia.org/r/363509
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib831c781f4fe91eef787aef3d17e71780be9da51
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
