jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/363512 )
Change subject: Forbid backtick operator
......................................................................
Forbid backtick operator
It is identical to shell_exec, which is much more clear.
There is only one use in MW core, which can be fixed when core
upgrades this library.
(I have seen this confused with single quote in practice.)
Change-Id: I900b1a292cfc5b07e4d06da886525a9778419e75
---
M MediaWiki/ruleset.xml
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/MediaWiki/ruleset.xml b/MediaWiki/ruleset.xml
index 91f7e6d..cae0a30 100644
--- a/MediaWiki/ruleset.xml
+++ b/MediaWiki/ruleset.xml
@@ -112,6 +112,7 @@
</rule>
<rule ref="Zend.Files.ClosingTag" />
+ <rule ref="Generic.PHP.BacktickOperator" />
<!-- exclude common folders from version control or build tools -->
<exclude-pattern type="relative">^.git</exclude-pattern>
--
To view, visit https://gerrit.wikimedia.org/r/363512
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I900b1a292cfc5b07e4d06da886525a9778419e75
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/codesniffer
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
