Legoktm has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/363518 )
Change subject: Add tests for forbidding use of backtick operator
......................................................................
Add tests for forbidding use of backtick operator
Follows-up affcecb0d7fb6.
Change-Id: I04b44f9abdb1921de4502a45bdca89a720f4c511
---
M MediaWiki/Tests/files/generic_fail.php
M MediaWiki/Tests/files/generic_fail.php.expect
2 files changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/codesniffer
refs/changes/18/363518/1
diff --git a/MediaWiki/Tests/files/generic_fail.php
b/MediaWiki/Tests/files/generic_fail.php
index 3c1cd35..276a614 100644
--- a/MediaWiki/Tests/files/generic_fail.php
+++ b/MediaWiki/Tests/files/generic_fail.php
@@ -3,3 +3,5 @@
if ( $a or $b ) {
$c = $a and $b;
}
+
+$foo = `echo "hi";`;
diff --git a/MediaWiki/Tests/files/generic_fail.php.expect
b/MediaWiki/Tests/files/generic_fail.php.expect
index 2550fb0..2aaf83b 100644
--- a/MediaWiki/Tests/files/generic_fail.php.expect
+++ b/MediaWiki/Tests/files/generic_fail.php.expect
@@ -1,4 +1,8 @@
3 | ERROR | Logical operator "or" is prohibited; use "||" instead
| | (Squiz.Operators.ValidLogicalOperators.NotAllowed)
4 | ERROR | Logical operator "and" is prohibited; use "&&" instead
- | | (Squiz.Operators.ValidLogicalOperators.NotAllowed)
\ No newline at end of file
+ | | (Squiz.Operators.ValidLogicalOperators.NotAllowed)
+ 7 | ERROR | Use of the backtick operator is forbidden
+ | | (Generic.PHP.BacktickOperator.Found)
+ 7 | ERROR | Use of the backtick operator is forbidden
+ | | (Generic.PHP.BacktickOperator.Found)
--
To view, visit https://gerrit.wikimedia.org/r/363518
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I04b44f9abdb1921de4502a45bdca89a720f4c511
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/codesniffer
Gerrit-Branch: master
Gerrit-Owner: Legoktm <lego...@member.fsf.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
