jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/363658 )
Change subject: Hygiene: Stop emitting global events that are not being used
anywhere
......................................................................
Hygiene: Stop emitting global events that are not being used anywhere
Remove unused events WatchstarGateway (watched) and
EditorOverlay (edit-preview)
Change-Id: I4bd2b73223f58f1000cfb26454ac6dd92673517d
---
M resources/mobile.editor.overlay/EditorOverlay.js
M resources/mobile.watchstar/WatchstarGateway.js
2 files changed, 0 insertions(+), 3 deletions(-)
Approvals:
Bmansurov: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/mobile.editor.overlay/EditorOverlay.js
b/resources/mobile.editor.overlay/EditorOverlay.js
index 145a73e..3713e5f 100644
--- a/resources/mobile.editor.overlay/EditorOverlay.js
+++ b/resources/mobile.editor.overlay/EditorOverlay.js
@@ -270,8 +270,6 @@
el: self.$preview,
text: parsedText
} ).$( 'a' ).on( 'click', false );
- // Emit event so we can perform enhancements to
page
- M.emit( 'edit-preview', self );
} ).fail( function () {
self.$preview.addClass( 'error' ).text( mw.msg(
'mobile-frontend-editor-error-preview' ) );
} ).always( function () {
diff --git a/resources/mobile.watchstar/WatchstarGateway.js
b/resources/mobile.watchstar/WatchstarGateway.js
index 0177ce2..14cb643 100644
--- a/resources/mobile.watchstar/WatchstarGateway.js
+++ b/resources/mobile.watchstar/WatchstarGateway.js
@@ -106,7 +106,6 @@
return this.api.postWithToken( 'watch', data ).done(
function () {
var newStatus = !self.isWatchedPage( page );
self.setWatchedPage( page, newStatus );
- M.emit( 'watched', page, newStatus );
} );
}
};
--
To view, visit https://gerrit.wikimedia.org/r/363658
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4bd2b73223f58f1000cfb26454ac6dd92673517d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
