jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/361083 )
Change subject: Remove advertise new feature in main menu
......................................................................
Remove advertise new feature in main menu
Remove code relating to pointer overlays in main menu
It's not being used (since Gather) and has been
neglected, is broken and cannot be trusted.
If we need to use this again we should revert this patch and
fix the problems.
Change-Id: I52bf15ea45bdad954822a0d91aef0f7661524de3
---
M resources/skins.minerva.mainMenu.styles/mainmenu.less
M resources/skins.minerva.mainMenu/MainMenu.js
M skinStyles/mobile.pointerOverlay/minerva.less
3 files changed, 0 insertions(+), 62 deletions(-)
Approvals:
Bmansurov: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/skins.minerva.mainMenu.styles/mainmenu.less
b/resources/skins.minerva.mainMenu.styles/mainmenu.less
index 9bc9fcd..4379032 100644
--- a/resources/skins.minerva.mainMenu.styles/mainmenu.less
+++ b/resources/skins.minerva.mainMenu.styles/mainmenu.less
@@ -26,23 +26,6 @@
position: relative;
}
-.main-menu-button {
- &.indicator-circle {
- overflow: initial;
- &:after {
- content: '';
- background-color: @colorProgressive;
- width: 0.65em;
- height: 0.65em;
- position: absolute;
- top: -0.4em;
- right: 0.6em;
- border: 0.2em solid #fff;
- border-radius: 0.5em;
- }
- }
-}
-
// needs to be more specific than .overlay rules
.notifications-overlay.navigation-drawer {
right: 0;
diff --git a/resources/skins.minerva.mainMenu/MainMenu.js
b/resources/skins.minerva.mainMenu/MainMenu.js
index 5a45472..babda9b 100644
--- a/resources/skins.minerva.mainMenu/MainMenu.js
+++ b/resources/skins.minerva.mainMenu/MainMenu.js
@@ -35,44 +35,6 @@
},
/**
- * Advertise a new feature in the main menu.
- * @param {string} selector to an element inside the main menu
- * @param {string} msg a message to show in the pointer
- * @return {jQuery.Deferred} with the PointerOverlay as the
only argument.
- * @throws exception when you try to advertise more than one
feature.
- */
- advertiseNewFeature: function ( selector, msg ) {
- var d = $.Deferred(),
- self = this;
- if ( this._hasNewFeature ) {
- throw new Error( 'A new feature is already
being advertised.' );
- } else {
- this._hasNewFeature = true;
- }
- $( function () {
- var $activator = $( self.activator ).eq( 0 );
- $activator.addClass( 'indicator-circle' );
- mw.loader.using( 'mobile.pointerOverlay'
).done( function () {
- $activator.one( 'click', function () {
- var po,
- PointerOverlay =
require( 'mobile.pointerOverlay' );
-
- po = new PointerOverlay( {
- appendToElement:
self.$el.parent(),
- alignment: 'left',
- summary: msg,
- target: self.$(
selector )
- } );
- po.show();
- d.resolve( po );
- $activator.removeClass(
'indicator-circle' );
- } );
- } );
- } );
- return d;
- },
-
- /**
* Turn on event logging on the existing main menu by reading
`event-name` data
* attributes on elements.
*/
diff --git a/skinStyles/mobile.pointerOverlay/minerva.less
b/skinStyles/mobile.pointerOverlay/minerva.less
index 9d626a0..de7373b 100644
--- a/skinStyles/mobile.pointerOverlay/minerva.less
+++ b/skinStyles/mobile.pointerOverlay/minerva.less
@@ -89,10 +89,3 @@
}
}
}
-
-.navigation-drawer {
- .pointer-overlay {
- right: auto;
- width: @menuWidth;
- }
-}
--
To view, visit https://gerrit.wikimedia.org/r/361083
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I52bf15ea45bdad954822a0d91aef0f7661524de3
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
