jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/363799 )
Change subject: Documentation: Fix return value of IDatabase::insertSelect()
......................................................................
Documentation: Fix return value of IDatabase::insertSelect()
Implementation at Database returns bool, not IResultWrapper
Change-Id: Ic560bfcb45f0e9cd1f4e8334e3b5dfc4e682452a
---
M includes/libs/rdbms/database/IDatabase.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Umherirrender: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/libs/rdbms/database/IDatabase.php
b/includes/libs/rdbms/database/IDatabase.php
index 7c6413c..e463ea3 100644
--- a/includes/libs/rdbms/database/IDatabase.php
+++ b/includes/libs/rdbms/database/IDatabase.php
@@ -1252,7 +1252,7 @@
* @param array $selectJoinConds Join conditions for the SELECT part of
the query, see
* IDatabase::select() for details.
*
- * @return IResultWrapper
+ * @return bool
*/
public function insertSelect( $destTable, $srcTable, $varMap, $conds,
$fname = __METHOD__,
--
To view, visit https://gerrit.wikimedia.org/r/363799
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic560bfcb45f0e9cd1f4e8334e3b5dfc4e682452a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Martineznovo <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
