jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/363756 )
Change subject: Make Phan tests pass
......................................................................
Make Phan tests pass
Change-Id: Iba9d41e30a68a2ce17ec890e1708a1196eda783d
---
M includes/LoginNotify.php
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Niharika29: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/LoginNotify.php b/includes/LoginNotify.php
index ad2014f..bb911e5 100644
--- a/includes/LoginNotify.php
+++ b/includes/LoginNotify.php
@@ -271,6 +271,8 @@
/**
* Actually do the query of the check user table.
*
+ * @suppress PhanTypeMismatchArgument
+ *
* @note This catches and ignores database errors.
* @param int $userId User id number (Not necessarily for the local
wiki)
* @param string $ipFragment Prefix to match against cuc_ip (from
$this->getIPNetwork())
@@ -304,6 +306,8 @@
* If we have no info for user, we maybe don't treat it as
* an unknown IP, since user has no known IPs.
*
+ * @suppress PhanTypeMismatchArgument
+ *
* @todo FIXME Does this behaviour make sense, esp. with cookie check?
* @param int $userId User id number (possibly on foreign wiki)
* @param Database $dbr DB connection (possibly to foreign wiki)
--
To view, visit https://gerrit.wikimedia.org/r/363756
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba9d41e30a68a2ce17ec890e1708a1196eda783d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LoginNotify
Gerrit-Branch: master
Gerrit-Owner: MaxSem <[email protected]>
Gerrit-Reviewer: Niharika29 <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
