jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/364167 )
Change subject: Fix a warning when second parameter is not an integer valaue (v
0.8.2)
......................................................................
Fix a warning when second parameter is not an integer valaue (v 0.8.2)
Change-Id: I9cc3ec8145b08afc445d6267adb197157b1fe948
---
M NumberFormat.php
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
Pastakhov: Looks good to me, approved
jenkins-bot: Verified
diff --git a/NumberFormat.php b/NumberFormat.php
index ef450d8..98fa060 100644
--- a/NumberFormat.php
+++ b/NumberFormat.php
@@ -8,7 +8,7 @@
'path' => __FILE__,
'name' => 'NumberFormat',
'namemsg' => 'numberformat-extensionname',
- 'version' => '0.8.1',
+ 'version' => '0.8.2',
'descriptionmsg' => 'numberformat_desc',
'author' => array(
'[https://www.mediawiki.org/wiki/User:Patrick_Nagel Patrick
Nagel]',
@@ -64,7 +64,6 @@
break;
case 0:
return ""; //Empty output for empty input
- break;
default:
return '<span class="error">' . wfMessage(
'numberformat_wrongnargs' )->escaped() . '</span>';
}
@@ -74,8 +73,8 @@
return '<span class="error">' . wfMessage(
'numberformat_firstargument' )->escaped() . '</span>';
}
$output = number_format(
- $params[0],
- isset( $params[1] ) ? $params[1] : null,
+ (float)$params[0],
+ isset( $params[1] ) ? (int)$params[1] : null,
isset( $params[2] ) ? $params[2] : null,
isset( $params[3] ) ? $params[3] : null
);
--
To view, visit https://gerrit.wikimedia.org/r/364167
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9cc3ec8145b08afc445d6267adb197157b1fe948
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/NumberFormat
Gerrit-Branch: master
Gerrit-Owner: Pastakhov <[email protected]>
Gerrit-Reviewer: Kghbln <[email protected]>
Gerrit-Reviewer: Pastakhov <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
