Jcrespo has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/364180 )

Change subject: mariadb: Test new multiinstance dbstore role on an empty host
......................................................................


mariadb: Test new multiinstance dbstore role on an empty host

Fix feature not yet implemented (multiinstance => true/false
parameter), which we do nothing about yet.

This will serve to check what things are missing/broken
for multi-instance hosts.

Bug: T169514
Change-Id: I3b96d7381756818d796846f79323906f03b3ebc4
---
M manifests/site.pp
M modules/role/manifests/mariadb/dbstore_multiinstance.pp
2 files changed, 6 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Jcrespo: Looks good to me, approved



diff --git a/manifests/site.pp b/manifests/site.pp
index 5c78b5f..6861827 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -683,6 +683,11 @@
     include ::base::firewall
 }
 
+# Temporary test multiinstance role host
+node 'db1096.eqiad.wmnet' {
+    role(mariadb::dbstore_multiinstance)
+}
+
 # Proxies for misc databases
 node /^dbproxy100(1|6)\.eqiad\.wmnet$/ {
     class { '::role::mariadb::proxy::master':
diff --git a/modules/role/manifests/mariadb/dbstore_multiinstance.pp 
b/modules/role/manifests/mariadb/dbstore_multiinstance.pp
index 802b32c..e1855eb 100644
--- a/modules/role/manifests/mariadb/dbstore_multiinstance.pp
+++ b/modules/role/manifests/mariadb/dbstore_multiinstance.pp
@@ -18,7 +18,7 @@
 
     class {'mariadb::packages_wmf': }
     class {'mariadb::service':
-        multiinstance => true,
+        # multiinstance => true, # for now, we will not do anything special
         # for now we will keep things simple, we probably should have a
         # higher-level interface with templates
         override      => "[Service]\nLimitNOFILE=200000",

-- 
To view, visit https://gerrit.wikimedia.org/r/364180
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3b96d7381756818d796846f79323906f03b3ebc4
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Jcrespo <[email protected]>
Gerrit-Reviewer: Jcrespo <[email protected]>
Gerrit-Reviewer: Marostegui <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to