Dbrant has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/364216 )
Change subject: Simplify error message upon failure to fetch random article.
......................................................................
Simplify error message upon failure to fetch random article.
Bug: T157377
Change-Id: I7820ea9babdc06955e734027497587b31644002b
---
M app/src/main/java/org/wikipedia/feed/FeedFragment.java
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/16/364216/1
diff --git a/app/src/main/java/org/wikipedia/feed/FeedFragment.java
b/app/src/main/java/org/wikipedia/feed/FeedFragment.java
index e821db7..70da074 100644
--- a/app/src/main/java/org/wikipedia/feed/FeedFragment.java
+++ b/app/src/main/java/org/wikipedia/feed/FeedFragment.java
@@ -35,6 +35,7 @@
import org.wikipedia.settings.SettingsActivity;
import org.wikipedia.util.FeedbackUtil;
import org.wikipedia.util.ResourceUtil;
+import org.wikipedia.util.ThrowableUtil;
import org.wikipedia.util.UriUtil;
import org.wikipedia.views.ExploreOverflowView;
@@ -385,7 +386,9 @@
@Override
public void onGetRandomError(@NonNull Throwable t, @NonNull final
RandomCardView view) {
- Snackbar snackbar = FeedbackUtil.makeSnackbar(getActivity(),
t.getMessage(), FeedbackUtil.LENGTH_DEFAULT);
+ Snackbar snackbar = FeedbackUtil.makeSnackbar(getActivity(),
ThrowableUtil.isOffline(t)
+ ? getString(R.string.view_wiki_error_message_offline) :
t.getMessage(),
+ FeedbackUtil.LENGTH_DEFAULT);
snackbar.setAction(R.string.page_error_retry, new
View.OnClickListener() {
@Override
public void onClick(View v) {
--
To view, visit https://gerrit.wikimedia.org/r/364216
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7820ea9babdc06955e734027497587b31644002b
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
