Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/364224 )
Change subject: Fix wikitext table insertion
......................................................................
Fix wikitext table insertion
Since Ic8b11d8052 #insertContent puts multiline strings on separate
lines, so to get this to behave correctly, pass in linear data instead.
Bug: T170160
Change-Id: Ie121fce1af46c6834945f4de30bcd9924ee96fd1
---
M modules/ve-mw/ui/ve.ui.MWWikitextCommandRegistry.js
1 file changed, 14 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/24/364224/1
diff --git a/modules/ve-mw/ui/ve.ui.MWWikitextCommandRegistry.js
b/modules/ve-mw/ui/ve.ui.MWWikitextCommandRegistry.js
index f606216..95a5145 100644
--- a/modules/ve-mw/ui/ve.ui.MWWikitextCommandRegistry.js
+++ b/modules/ve-mw/ui/ve.ui.MWWikitextCommandRegistry.js
@@ -219,16 +219,20 @@
new ve.ui.Command(
'insertTable', 'mwWikitext', 'toggleWrapSelection',
{
- args: [ '{| class="wikitable"\n', '\n|}', function () {
- return '' +
- '|+ ' + ve.msg(
'visualeditor-table-caption' ) +
- '\n' +
- '! ' + ve.msg(
'visualeditor-table-format-header' ) + ' !! ' + ve.msg(
'visualeditor-table-format-header' ) +
- '\n' +
- '|-' +
- '\n' +
- '| ' + ve.msg(
'visualeditor-table-format-data' ) + ' || ' + ve.msg(
'visualeditor-table-format-data' );
- } ],
+ args: [
+ [ { type: 'paragraph' } ].concat( '{|
class="wikitable"'.split( '' ) ).concat( { type: '/paragraph' } ),
+ [ { type: 'paragraph' } ].concat( '|}'.split(
'' ) ).concat( { type: '/paragraph' } ),
+ function () {
+ return '' +
+ '|+ ' + ve.msg(
'visualeditor-table-caption' ) +
+ '\n' +
+ '! ' + ve.msg(
'visualeditor-table-format-header' ) + ' !! ' + ve.msg(
'visualeditor-table-format-header' ) +
+ '\n' +
+ '|-' +
+ '\n' +
+ '| ' + ve.msg(
'visualeditor-table-format-data' ) + ' || ' + ve.msg(
'visualeditor-table-format-data' );
+ }
+ ],
supportedSelections: [ 'linear' ]
}
)
--
To view, visit https://gerrit.wikimedia.org/r/364224
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie121fce1af46c6834945f4de30bcd9924ee96fd1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
