jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/364218 )
Change subject: getSourceText: Fix edge case
......................................................................
getSourceText: Fix edge case
Remove assumption that data[i+1] exists, that
was the case before because of the internal list
but doesn't work with doc fragments.
Change-Id: I93bb2b5dcc92c60cef6daa97616c8a8203618832
---
M src/dm/lineardata/ve.dm.ElementLinearData.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/src/dm/lineardata/ve.dm.ElementLinearData.js
b/src/dm/lineardata/ve.dm.ElementLinearData.js
index f3b4e75..9b4d319 100644
--- a/src/dm/lineardata/ve.dm.ElementLinearData.js
+++ b/src/dm/lineardata/ve.dm.ElementLinearData.js
@@ -774,7 +774,7 @@
range = range || new ve.Range( 0, this.getLength() );
for ( i = range.start; i < range.end; i++ ) {
- if ( data[ i ].type === '/paragraph' && data[ i + 1 ].type ===
'paragraph' ) {
+ if ( data[ i ].type === '/paragraph' && data[ i + 1 ] && data[
i + 1 ].type === 'paragraph' ) {
text += '\n';
} else if ( !data[ i ].type ) {
text += data[ i ];
--
To view, visit https://gerrit.wikimedia.org/r/364218
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I93bb2b5dcc92c60cef6daa97616c8a8203618832
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
