jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/363021 )
Change subject: Remove unused, dead code from Lexeme's ControllerViewFactory
......................................................................
Remove unused, dead code from Lexeme's ControllerViewFactory
Change-Id: Ic707fcc8a7abbcb2c378a2ac08c861d98f07bc31
---
M resources/view/ControllerViewFactory.js
M src/DataModel/Services/Diff/LexemeDiffer.php
2 files changed, 11 insertions(+), 42 deletions(-)
Approvals:
Aleksey Bekh-Ivanov (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/view/ControllerViewFactory.js
b/resources/view/ControllerViewFactory.js
index 8905c8d..3276a30 100644
--- a/resources/view/ControllerViewFactory.js
+++ b/resources/view/ControllerViewFactory.js
@@ -107,17 +107,6 @@
);
};
- var fakeModel = { // FIXME: replace with EntityChanger
- save: function ( form ) {
- var deferred = $.Deferred();
- if ( !form.getId() ) {
- form._id = Math.round( Math.random() * 100 );
- }
- deferred.resolve( form );
- return deferred.promise();
- }
- };
-
SELF.prototype.getLexemeFormView = function (
lexemeId,
form,
@@ -126,15 +115,13 @@
startEditingCallback,
removeCallback
) {
- var self = this;
-
var lexemeFormView = this._getView(
'lexemeformview',
$dom,
{
value: form || new
wb.lexeme.datamodel.LexemeForm(),
labelFormattingService:
labelFormattingService,
- api: self._api,
+ api: this._api,
buildStatementGroupListView:
this.getStatementGroupListView.bind(
this,
startEditingCallback
@@ -178,8 +165,6 @@
startEditingCallback,
removeCallback
) {
- var self = this;
-
var senseView = this._getView(
'senseview',
$dom,
@@ -190,15 +175,16 @@
startEditingCallback
)
}
- ),
- controller = this._getController(
- this._toolbarFactory.getToolbarContainer(
senseView.element ),
- senseView,
- fakeSenseModelCreator( lexemeId ),
- removeCallback.bind( null, senseView ),
- sense,
- startEditingCallback
- );
+ );
+
+ this._getController(
+ this._toolbarFactory.getToolbarContainer(
senseView.element ),
+ senseView,
+ fakeSenseModelCreator( lexemeId ),
+ removeCallback.bind( null, senseView ),
+ sense,
+ startEditingCallback
+ );
return senseView;
};
@@ -282,20 +268,6 @@
} );
return features;
- };
-
- SELF.prototype._getExistingGrammaticalFeatures = function ( $element ) {
- var existingGrammaticalFeatures = $.map( $element.find(
'.wikibase-lexeme-form-grammatical-features-values > a' ), function ( el ) {
- return $( el ).attr( 'title' );
- } ).filter( Boolean ).map( function ( title ) {
- return title.match( /Q\d+/ )[ 0 ];
- } );
-
- var deletedGrammaticalFeatures = $.map( $element.find(
'.wikibase-lexeme-form-grammatical-features-values .wb-entity-undefinedinfo' ),
function ( el ) {
- return el.previousSibling.nodeValue.match( /Q\d+/ )[ 0
];
- } ).filter( Boolean );
-
- return existingGrammaticalFeatures.concat(
deletedGrammaticalFeatures );
};
SELF.prototype.getListItemAdapterForSenseListView = function ( lexeme,
startEditingCallback, removeCallback ) {
diff --git a/src/DataModel/Services/Diff/LexemeDiffer.php
b/src/DataModel/Services/Diff/LexemeDiffer.php
index b174a5b..374c147 100644
--- a/src/DataModel/Services/Diff/LexemeDiffer.php
+++ b/src/DataModel/Services/Diff/LexemeDiffer.php
@@ -27,9 +27,6 @@
*/
private $recursiveMapDiffer;
- /**
- * LexemeDiffer constructor.
- */
public function __construct() {
$this->recursiveMapDiffer = new MapDiffer( true );
$this->statementListDiffer = new StatementListDiffer();
--
To view, visit https://gerrit.wikimedia.org/r/363021
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic707fcc8a7abbcb2c378a2ac08c861d98f07bc31
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Aleksey Bekh-Ivanov (WMDE) <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
