MaxSem has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/364257 )
Change subject: Fix message and documentation mismatch
......................................................................
Fix message and documentation mismatch
Bug: T170043
Change-Id: I86e5cdb753aeaae1f08a79430499d80ebe9c825d
---
M i18n/en.json
M i18n/qqq.json
M includes/PresentationModel.php
3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LoginNotify
refs/changes/57/364257/1
diff --git a/i18n/en.json b/i18n/en.json
index fa43439..b3c9b7f 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -14,7 +14,7 @@
"loginnotify-primary-link": "Help",
"notification-loginnotify-login-fail-email-subject":
"{{PLURAL:$2|Failed attempt|Multiple failed attempts}} to log in to
{{SITENAME}} as $1",
"notification-loginnotify-login-success-email-subject": "Login to
{{SITENAME}} as $1 from a computer you have not recently used",
- "notification-header-login-success": "Someone (probably you) recently
logged in to your account from a new device. If this was you, then you can
disregard this message. If it wasn't you, then it's recommended that you change
your password, and check your account activity.",
+ "notification-header-login-success": "Someone (probably
{{GENDER:$1|you}}) recently logged in to your account from a new device. If
this was you, then you can disregard this message. If it wasn't you, then it's
recommended that you change your password, and check your account activity.",
"notification-new-bundled-header-login-fail": "There {{PLURAL:$1|has
been '''a failed attempt'''|have been '''$1 failed attempts'''}} to log in to
your account from a new device since the last time you logged in. If it wasn't
you, please make sure your account has a strong password.",
"notification-known-header-login-fail": "There have been
{{PLURAL:$1|has been '''a failed attempt'''|have been '''$1 failed
attempts'''}} to log in to your account since the last time you logged in. If
it wasn't you, please make sure your account has a strong password.",
"notification-new-unbundled-header-login-fail": "There {{PLURAL:$1|has
been '''a failed attempt'''|have been '''multiple failed attempts'''}} to log
in to your account from a new device. Please make sure your account has a
strong password."
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 3d7c89b..4c80696 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -14,7 +14,7 @@
"loginnotify-primary-link": "Label for link to a help page about the
feature\n{{Identical|Help}}",
"notification-loginnotify-login-fail-email-subject": "Email subject
line for email notice that there have been failed login attempts for the user's
account. $1 is the user in question.",
"notification-loginnotify-login-success-email-subject": "Email subject
line for email notice that someone has logged in to the user's account from a
computer that has not previously been used. $1 is the user in question.",
- "notification-header-login-success": "Text of notification for when
someone successfully logs in as the current account from a computer that has
not been previously used by that account. This is shown in the user's echo
notifications, and is possibly emailed to the user.\n* $1 = Username for
account, formatted for display\n* $2 = Username for account, unformatted for
use in GENDER",
+ "notification-header-login-success": "Text of notification for when
someone successfully logs in as the current account from a computer that has
not been previously used by that account. This is shown in the user's echo
notifications, and is possibly emailed to the user.\n* $1 = Username for
account, for use in GENDER",
"notification-new-bundled-header-login-fail": "Message string shown for
bundled notifications for login attempts from a new device",
"notification-known-header-login-fail": "Message string shown for known
IP notifications",
"notification-new-unbundled-header-login-fail": "Message string shown
for individual notifications for login attempts from a new device, when the
bundle disperses"
diff --git a/includes/PresentationModel.php b/includes/PresentationModel.php
index e359e99..9031c04 100644
--- a/includes/PresentationModel.php
+++ b/includes/PresentationModel.php
@@ -71,7 +71,7 @@
}
break;
default:
- $msg = $this->msg(
'notification-header-login-success' );
+ $msg = $this->msg(
'notification-header-login-success', $this->getUser() );
}
return $msg;
}
--
To view, visit https://gerrit.wikimedia.org/r/364257
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I86e5cdb753aeaae1f08a79430499d80ebe9c825d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LoginNotify
Gerrit-Branch: master
Gerrit-Owner: MaxSem <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
