jenkins-bot has submitted this change and it was merged. Change subject: Adding comments for grep ......................................................................
Adding comments for grep Change-Id: Idbbd480dd980784cc0bb2262dd21479d51471f31 --- M MwEmbedModules/EmbedPlayer/resources/mw.MediaPlayer.js M MwEmbedModules/EmbedPlayer/resources/skins/kskin/mw.PlayerSkinKskin.js M MwEmbedModules/TimedText/resources/mw.TimedText.js M SpecialTimedMediaHandler.php M TimedMediaHandler_body.php M WebVideoTranscode/WebVideoTranscode.php 6 files changed, 23 insertions(+), 0 deletions(-) Approvals: Siebrand: Looks good to me, approved jenkins-bot: Verified diff --git a/MwEmbedModules/EmbedPlayer/resources/mw.MediaPlayer.js b/MwEmbedModules/EmbedPlayer/resources/mw.MediaPlayer.js index 16b70c1..8b52f53 100644 --- a/MwEmbedModules/EmbedPlayer/resources/mw.MediaPlayer.js +++ b/MwEmbedModules/EmbedPlayer/resources/mw.MediaPlayer.js @@ -53,6 +53,13 @@ * Get the "name" of the player from a predictable msg key */ getName: function() { + // Give grep a chance to find the usages: + // mwe-embedplayer-ogg-player-vlc-player, mwe-embedplayer-ogg-player-oggNative, mwe-embedplayer-ogg-player-mp3Native, + // mwe-embedplayer-ogg-player-aacNative, mwe-embedplayer-ogg-player-h264Native, mwe-embedplayer-ogg-player-webmNative, + // mwe-embedplayer-ogg-player-oggPlugin, mwe-embedplayer-ogg-player-quicktime-mozilla, + // mwe-embedplayer-ogg-player-quicktime-activex, mwe-embedplayer-ogg-player-cortado, + // mwe-embedplayer-ogg-player-flowplayer, mwe-embedplayer-ogg-player-kplayer, mwe-embedplayer-ogg-player-selected, + // mwe-embedplayer-ogg-player-omtkplayer return mw.msg( 'mwe-embedplayer-ogg-player-' + this.id ); }, diff --git a/MwEmbedModules/EmbedPlayer/resources/skins/kskin/mw.PlayerSkinKskin.js b/MwEmbedModules/EmbedPlayer/resources/skins/kskin/mw.PlayerSkinKskin.js index 83ec10a..1f9ced1 100644 --- a/MwEmbedModules/EmbedPlayer/resources/skins/kskin/mw.PlayerSkinKskin.js +++ b/MwEmbedModules/EmbedPlayer/resources/skins/kskin/mw.PlayerSkinKskin.js @@ -106,6 +106,9 @@ // Output menu item containers: for ( var menuItem in ctrlObj.supportedMenuItems ) { + // Give grep a chance to find the usages: + // mwe-embedplayer-playerSelect, mwe-embedplayer-download, + // mwe-embedplayer-share, mwe-embedplayer-credits $menuBar.append( $( '<li />') // Add the menu item class: diff --git a/MwEmbedModules/TimedText/resources/mw.TimedText.js b/MwEmbedModules/TimedText/resources/mw.TimedText.js index 75a90ba..bd135c2 100644 --- a/MwEmbedModules/TimedText/resources/mw.TimedText.js +++ b/MwEmbedModules/TimedText/resources/mw.TimedText.js @@ -1043,6 +1043,11 @@ ); } // Append a cat menu item for each kind list + // Give grep a chance to find the usages: + // mwe-timedtext-textcat-cc, mwe-timedtext-textcat-sub, mwe-timedtext-textcat-tad, + // mwe-timedtext-textcat-ktv, mwe-timedtext-textcat-tik, mwe-timedtext-textcat-ar, + // mwe-timedtext-textcat-nb, mwe-timedtext-textcat-meta, mwe-timedtext-textcat-trx, + // mwe-timedtext-textcat-lrc, mwe-timedtext-textcat-lin, mwe-timedtext-textcat-cue $langMenu.append( $.getLineItem( mw.msg( 'mwe-timedtext-textcat-' + categoryKey.toLowerCase() ) ).append( $catChildren diff --git a/SpecialTimedMediaHandler.php b/SpecialTimedMediaHandler.php index 6f91ea4..9910cc1 100644 --- a/SpecialTimedMediaHandler.php +++ b/SpecialTimedMediaHandler.php @@ -36,6 +36,7 @@ . $this->msg( 'timedmedia-videos', $stats['videos']['total'] )->escaped() . "</h2>" ); + // Give grep a chance to find the usages: timedmedia-ogg-videos, timedmedia-webm-videos foreach ( $this->formats as $format => $condition ) { if ( $stats[ 'videos' ][ $format ] ) { $out->addHTML( @@ -59,6 +60,9 @@ private function renderState ( $out, $state, $stats, $showTable = true ) { global $wgEnabledTranscodeSet; if ( $stats[ $state ][ 'total' ] ) { + // Give grep a chance to find the usages: + // timedmedia-derivative-state-transcodes, timedmedia-derivative-state-active, + // timedmedia-derivative-state-queued, timedmedia-derivative-state-failed $out->addHTML( "<h2>" . $this->msg( 'timedmedia-derivative-state-' . $state, $stats[ $state ]['total'] )->escaped() diff --git a/TimedMediaHandler_body.php b/TimedMediaHandler_body.php index d12e5ea..e3d94bb 100644 --- a/TimedMediaHandler_body.php +++ b/TimedMediaHandler_body.php @@ -201,6 +201,8 @@ if($v == 0 ){ unset( $t[$k] ); } else { + // Give grep a chance to find the usages: + // timedmedia-days, timedmedia-hours, timedmedia-minutes,timedmedia-seconds $t[$k] = wfMessage( 'timedmedia-' . $k, $v )->text(); } } diff --git a/WebVideoTranscode/WebVideoTranscode.php b/WebVideoTranscode/WebVideoTranscode.php index 1496a48..26ae494 100644 --- a/WebVideoTranscode/WebVideoTranscode.php +++ b/WebVideoTranscode/WebVideoTranscode.php @@ -680,6 +680,7 @@ $bitrate = $file->getHandler()->getBitrate( $file ); $metadataType = $file->getHandler()->getMetadataType( $file ); + // Give grep a chance to find the usages: timedmedia-ogg, timedmedia-webm, timedmedia-mp4 if( $file->getHandler()->isAudio( $file ) ){ $title = wfMessage( 'timedmedia-source-audio-file-desc', wfMessage( 'timedmedia-' . $metadataType )->text() ) @@ -691,6 +692,7 @@ ->params( $wgLang->formatBitrate( $bitrate ) )->text(); } + // Give grep a chance to find the usages: timedmedia-ogg, timedmedia-webm, timedmedia-mp4 $source = array( 'src' => $src, 'type' => $file->getHandler()->getWebType( $file ), -- To view, visit https://gerrit.wikimedia.org/r/53027 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbbd480dd980784cc0bb2262dd21479d51471f31 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: Shirayuki <shirayuk...@gmail.com> Gerrit-Reviewer: Siebrand <siebr...@wikimedia.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits