Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/364334 )

Change subject: ve.ui.MWSyntaxHighlightWindow: Set $overlay for the 
ComboBoxInputWidget
......................................................................

ve.ui.MWSyntaxHighlightWindow: Set $overlay for the ComboBoxInputWidget

* Allows the dropdown menu to extend outside of the dialog.
* Avoid z-index conflicts with Ace scrollbars (T170027).

Bug: T170027
Change-Id: I52d2d06b56391f30be07c71a86d71d9ab50f0a8c
---
M modules/ve-syntaxhighlight/ve.ui.MWSyntaxHighlightWindow.js
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SyntaxHighlight_GeSHi 
refs/changes/34/364334/1

diff --git a/modules/ve-syntaxhighlight/ve.ui.MWSyntaxHighlightWindow.js 
b/modules/ve-syntaxhighlight/ve.ui.MWSyntaxHighlightWindow.js
index 3ce7dda..beaf1f3 100644
--- a/modules/ve-syntaxhighlight/ve.ui.MWSyntaxHighlightWindow.js
+++ b/modules/ve-syntaxhighlight/ve.ui.MWSyntaxHighlightWindow.js
@@ -37,6 +37,7 @@
        var noneMsg = ve.msg( 
'syntaxhighlight-visualeditor-mwsyntaxhighlightinspector-none' );
 
        this.language = new OO.ui.ComboBoxInputWidget( {
+               $overlay: this.$overlay,
                menu: {
                        filterFromInput: true,
                        items: $.map( 
ve.dm.MWSyntaxHighlightNode.static.getLanguages(), function ( lang ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/364334
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I52d2d06b56391f30be07c71a86d71d9ab50f0a8c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SyntaxHighlight_GeSHi
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to