jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/364141 )
Change subject: Remove $wgBlogPageDisplay['left_ad'] feature that was never
completed
......................................................................
Remove $wgBlogPageDisplay['left_ad'] feature that was never completed
This is a feature that was leftover from the past (ArmchairGM/Wikia NYC)
which was never completed. There's no point in having it inside here
anyways, as there's extensions such as ShoutWikiAds that already
provide an advertisement feature.
Change-Id: I0f0c7653f9fd49470644703a48b1c154f43395bc
---
M extension.json
M includes/BlogPage.class.php
M resources/css/ext.blogpage.blogpage.css
3 files changed, 1 insertion(+), 32 deletions(-)
Approvals:
Jack Phoenix: Looks good to me, approved
jenkins-bot: Verified
diff --git a/extension.json b/extension.json
index 59cd130..713db0b 100644
--- a/extension.json
+++ b/extension.json
@@ -1,6 +1,6 @@
{
"name": "BlogPage",
- "version": "2.5.0",
+ "version": "2.6.0",
"author": [
"David Pean",
"Jack Phoenix"
@@ -30,7 +30,6 @@
"author_articles": true,
"recent_editors": true,
"recent_voters": true,
- "left_ad": false,
"popular_articles": true,
"in_the_news": true,
"comments_of_day": true,
diff --git a/includes/BlogPage.class.php b/includes/BlogPage.class.php
index 9caf282..c1cd48d 100644
--- a/includes/BlogPage.class.php
+++ b/includes/BlogPage.class.php
@@ -678,26 +678,6 @@
}
/**
- * Get an ad unit for the left side, if this feature is enabled in
BlogPage
- * config.
- *
- * @return string HTML or nothing
- */
- public function leftAdUnit() {
- global $wgBlogPageDisplay;
-
- if ( $wgBlogPageDisplay['left_ad'] == false ) {
- return '';
- }
-
- $output = '<div class="article-ad">
- <!-- BlogPage ad temporarily disabled -->
- </div>';
-
- return $output;
- }
-
- /**
* Get some random news items from MediaWiki:Inthenews, if this feature
is
* enabled in BlogPage config and that interface message has some
content.
*
diff --git a/resources/css/ext.blogpage.blogpage.css
b/resources/css/ext.blogpage.blogpage.css
index a396224..db6ee66 100644
--- a/resources/css/ext.blogpage.blogpage.css
+++ b/resources/css/ext.blogpage.blogpage.css
@@ -227,16 +227,6 @@
vertical-align: middle;
}
-/* Ad Unit */
-.article-ad {
- margin: 10px;
- text-align: center;
-}
-
-.article-ad a {
- text-align: inherit;
-}
-
/* Casual Game */
.game-unit-container {
padding: 0 0 10px 0;
--
To view, visit https://gerrit.wikimedia.org/r/364141
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f0c7653f9fd49470644703a48b1c154f43395bc
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/BlogPage
Gerrit-Branch: master
Gerrit-Owner: SamanthaNguyen <samanthanguyen1...@gmail.com>
Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
