Robert Vogel has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/364186 )
Change subject: BSVisualEditor: Fixed undefined menu item
......................................................................
BSVisualEditor: Fixed undefined menu item
* whenever the config array for the makeMenuItems was missing - due to
configuraton - there was a "TypeError" given
Change-Id: Ie4e210b853aff71e53a067b0a86ccd97ba6c4d1b
---
M VisualEditor/resources/tiny_mce_plugins/bsactions/plugin.js
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Robert Vogel: Verified
Mglaser: Looks good to me, approved
diff --git a/VisualEditor/resources/tiny_mce_plugins/bsactions/plugin.js
b/VisualEditor/resources/tiny_mce_plugins/bsactions/plugin.js
index 879c860..b3557b9 100644
--- a/VisualEditor/resources/tiny_mce_plugins/bsactions/plugin.js
+++ b/VisualEditor/resources/tiny_mce_plugins/bsactions/plugin.js
@@ -267,6 +267,7 @@
};
this.makeMenuItems = function( itemlist ) {
+ itemlist = itemlist || [];
var menuItems = [];
for ( var i = 0; i < itemlist.length; i++ ) {
var item_format = itemlist[i];
--
To view, visit https://gerrit.wikimedia.org/r/364186
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4e210b853aff71e53a067b0a86ccd97ba6c4d1b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: master
Gerrit-Owner: Pwirth <[email protected]>
Gerrit-Reviewer: Mglaser <[email protected]>
Gerrit-Reviewer: Robert Vogel <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
