Matthias Mullie has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/364426 )

Change subject: Resolve successful 1-chunk uploads
......................................................................

Resolve successful 1-chunk uploads

Existing code would assume there's always more than one chunk,
or it would otherwise not resolve.

Upload dialog started doing chunked uploads recently[1]:
Ib9cc2c77a27658accf728fb37f8cebc879a467d2

Change-Id: I29a85c5ee6fbf6cea7d07e3281279b4ea3d87188
---
M resources/src/mediawiki/api/upload.js
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/26/364426/1

diff --git a/resources/src/mediawiki/api/upload.js 
b/resources/src/mediawiki/api/upload.js
index 9814142..219dfb8 100644
--- a/resources/src/mediawiki/api/upload.js
+++ b/resources/src/mediawiki/api/upload.js
@@ -348,6 +348,7 @@
 
                        // Submit first chunk to get the filekey
                        active = promise = this.uploadChunk( file, data, 0, 
chunkSize, '', chunkRetries )
+                               .done( chunkSize >= file.size ? 
deferred.resolve : null )
                                .fail( deferred.reject )
                                .progress( deferred.notify );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/364426
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I29a85c5ee6fbf6cea7d07e3281279b4ea3d87188
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to