Dbrant has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/364431 )
Change subject: Hygiene: a bit more post-mwapi cleanup.
......................................................................
Hygiene: a bit more post-mwapi cleanup.
Change-Id: I50f2be449d0200e48c7ad48fabd76f197d792bd3
---
M app/proguard-rules.pro
M app/src/main/java/org/wikipedia/page/PageFragmentLoadState.java
2 files changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/31/364431/1
diff --git a/app/proguard-rules.pro b/app/proguard-rules.pro
index 123326e..f3e7122 100644
--- a/app/proguard-rules.pro
+++ b/app/proguard-rules.pro
@@ -39,8 +39,6 @@
-dontnote butterknife.internal.**
# --- /Butter Knife ---
--keep class com.mobsandgeeks.saripaar.** {*;}
-
# --- Retrofit2 ---
-dontwarn retrofit2.**
-keep class retrofit2.** { *; }
diff --git a/app/src/main/java/org/wikipedia/page/PageFragmentLoadState.java
b/app/src/main/java/org/wikipedia/page/PageFragmentLoadState.java
index c4a98cc..1b8f35a 100644
--- a/app/src/main/java/org/wikipedia/page/PageFragmentLoadState.java
+++ b/app/src/main/java/org/wikipedia/page/PageFragmentLoadState.java
@@ -552,7 +552,7 @@
if (error != null) {
commonSectionFetchOnCatch(new MwException((MwServiceError)
error), startSequenceNum);
} else {
- commonSectionFetchOnCatch(new IOException("An unknown error
occurred."), startSequenceNum);
+ commonSectionFetchOnCatch(new
IOException(getResources().getString(R.string.error_unknown)),
startSequenceNum);
}
return;
}
--
To view, visit https://gerrit.wikimedia.org/r/364431
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50f2be449d0200e48c7ad48fabd76f197d792bd3
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
