jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/364419 )
Change subject: Add browser test for adding senses.
......................................................................
Add browser test for adding senses.
Bug: T169639
Change-Id: I5c9b93a0f0cff25edeaea1e2a9d6b83757d3f247
---
M tests/browser/features/senses.feature
M tests/browser/features/step_definitions/senses_steps.rb
M tests/browser/features/support/pages/lexeme_page.rb
3 files changed, 22 insertions(+), 2 deletions(-)
Approvals:
WMDE-leszek: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/senses.feature
b/tests/browser/features/senses.feature
index 531c3ae..724dce8 100644
--- a/tests/browser/features/senses.feature
+++ b/tests/browser/features/senses.feature
@@ -48,3 +48,11 @@
And I save the Sense
# TODO refresh page
Then I don't see that Gloss definition
+
+ @integration
+ Scenario: Adding Senses
+ When I click on the Senses list add button
+ And I add a Gloss for "en" language with value "Whatever"
+ And I save the Sense
+ # TODO refresh page
+ Then I should see a new Sense with that Gloss
diff --git a/tests/browser/features/step_definitions/senses_steps.rb
b/tests/browser/features/step_definitions/senses_steps.rb
index b3ccd5e..6fe8e29 100644
--- a/tests/browser/features/step_definitions/senses_steps.rb
+++ b/tests/browser/features/step_definitions/senses_steps.rb
@@ -55,6 +55,7 @@
new_gloss = @sense_I_am_currently_editing.glosses[-1]
new_gloss.language_input = language_code
new_gloss.value_input = gloss_value
+ @new_gloss = { value: gloss_value, language: language_code }
end
And(/^I remove the first Gloss definition$/) do
@@ -81,3 +82,14 @@
Then(/^I don't see that Gloss definition$/) do
expect(@sense_I_am_currently_editing.gloss?(@removed_gloss_language,
@removed_gloss_value)).to be false
end
+
+When(/^I click on the Senses list add button$/) do
+ on(LexemePage).add_sense_element.when_visible.click
+ @sense_I_am_currently_editing = on(LexemePage).senses[-1]
+end
+
+Then(/^I should see a new Sense with that Gloss$/) do
+ last_sense_gloss = on(LexemePage).senses[-1].glosses[-1]
+ expect(last_sense_gloss.language_element.when_visible.text).to
eq(@new_gloss[:language])
+ expect(last_sense_gloss.value_element.when_visible.text).to
eq(@new_gloss[:value])
+end
diff --git a/tests/browser/features/support/pages/lexeme_page.rb
b/tests/browser/features/support/pages/lexeme_page.rb
index d9e28a3..b33a7bd 100644
--- a/tests/browser/features/support/pages/lexeme_page.rb
+++ b/tests/browser/features/support/pages/lexeme_page.rb
@@ -76,7 +76,7 @@
class GlossDefinition
include PageObject
- element(:language, class: 'wikibase-lexeme-sense-gloss-language')
+ span(:language, css: '.wikibase-lexeme-sense-gloss-language > span')
text_field(:language_input, class:
'wikibase-lexeme-sense-gloss-language-input')
span(:value, class: 'wikibase-lexeme-sense-gloss-value')
text_field(:value_input, class: 'wikibase-lexeme-sense-gloss-value-input')
@@ -121,8 +121,8 @@
page_sections(:forms, LexemeForm, class: 'wikibase-lexeme-form')
page_sections(:senses, Sense, class: 'wikibase-lexeme-sense')
- # Lexeme Form
a(:add_lexeme_form, css: '.wikibase-lexeme-forms-section >
.wikibase-addtoolbar-container a')
+ a(:add_sense, css: '.wikibase-lexeme-senses-section >
.wikibase-addtoolbar-container a')
def create_lexeme(lexeme_data)
wb_api = MediawikiApi::Wikidata::WikidataClient.new URL.repo_api
--
To view, visit https://gerrit.wikimedia.org/r/364419
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c9b93a0f0cff25edeaea1e2a9d6b83757d3f247
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: Jakob <[email protected]>
Gerrit-Reviewer: Aleksey Bekh-Ivanov (WMDE) <[email protected]>
Gerrit-Reviewer: WMDE-leszek <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
