VolkerE has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/364453 )
Change subject: DraggableGroupElement: Move ARIA role to DraggableGroupWidget
......................................................................
DraggableGroupElement: Move ARIA role to DraggableGroupWidget
Moving ARIA role `listbox` to DraggableGroupWidget as we can't make
sure that DraggableGroupElement isn't used in different ARIA context
as mixin like for example in TagMultiselectWidgets.
Bug: T170267
Change-Id: Ide2d4f011db22d397f0b6a52c07a4799bb9cb37f
---
M demos/classes/DraggableGroupWidget.js
M src/mixins/DraggableGroupElement.js
2 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/53/364453/1
diff --git a/demos/classes/DraggableGroupWidget.js
b/demos/classes/DraggableGroupWidget.js
index aa13875..2c4f8b9 100644
--- a/demos/classes/DraggableGroupWidget.js
+++ b/demos/classes/DraggableGroupWidget.js
@@ -12,6 +12,9 @@
// Mixin constructors
OO.ui.mixin.DraggableGroupElement.call( this, $.extend( {}, config, {
$group: this.$element } ) );
+
+ // Initialize
+ this.$element.attr( 'role', 'listbox' );
};
/* Setup */
diff --git a/src/mixins/DraggableGroupElement.js
b/src/mixins/DraggableGroupElement.js
index 417a974..02425f1 100644
--- a/src/mixins/DraggableGroupElement.js
+++ b/src/mixins/DraggableGroupElement.js
@@ -48,7 +48,6 @@
}
this.$element
.addClass( 'oo-ui-draggableGroupElement' )
- .attr( 'role', 'listbox' )
.append( this.$status )
.toggleClass( 'oo-ui-draggableGroupElement-horizontal',
this.orientation === 'horizontal' );
};
--
To view, visit https://gerrit.wikimedia.org/r/364453
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide2d4f011db22d397f0b6a52c07a4799bb9cb37f
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
