Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364455 )
Change subject: POC: Send disabled event from JS after Preferences save ...................................................................... POC: Send disabled event from JS after Preferences save First we tried to send `disabled` event from PHP on successful Preferences form save. But we found out that we do not have access to many required properties like `sessionToken` or `previewCountBucket`. This is a Proof-of-concept to send an event via mini-module loaded on MediaWiki that on load compares old and current `isEnabled` config variable. When var is different (it was enabled before and now it's disabled) it triggers the `disabled` event. Changes: - introduced new module ext.popups.preferences TODO: - missing unit tests - add module only on preferences page - move getEventLogginTracker to intrumentation Bug: T167365 Change-Id: Id94cb98173cb52e0691e522de479d509e500876a --- M extension.json M includes/PopupsHooks.php M resources/dist/index.js M resources/dist/index.js.map A resources/dist/preferences.js A resources/dist/preferences.js.map M src/instrumentation/eventLogging.js A src/preferences.js M src/reducers/eventLogging.js M webpack.config.js 10 files changed, 126 insertions(+), 32 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups refs/changes/55/364455/1 -- To view, visit https://gerrit.wikimedia.org/r/364455 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id94cb98173cb52e0691e522de479d509e500876a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Pmiazga <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
