Lbenedix has uploaded a new change for review.
https://gerrit.wikimedia.org/r/53379
Change subject: added wfAppendQuery to the Specialpagelinks with parameters to
fix an issue in an environment where only index.php?title=Special:Foo works
......................................................................
added wfAppendQuery to the Specialpagelinks with parameters to fix an issue in
an environment where only index.php?title=Special:Foo works
Change-Id: I20c0550c0cb22101bd68529ec1c9e51718f62364
---
M SpecialUiFeedback.php
M UiFeedback.php
2 files changed, 11 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UIFeedback
refs/changes/79/53379/1
diff --git a/SpecialUiFeedback.php b/SpecialUiFeedback.php
index 371899b..0e61963 100644
--- a/SpecialUiFeedback.php
+++ b/SpecialUiFeedback.php
@@ -167,9 +167,9 @@
\//_____/ \/ \/ \/ */
/* add page-navigation */
$output_text .='<div class="page_navi">';
- if($id>1) $output_text .= ' <a
href="'.SpecialPage::getTitleFor( 'UiFeedback'
)->getFullURL().'?id='.($id-1).'" >'.wfMessage(
'ui-feedback-special-navi-previous' )->text().'</a> | ';
- $output_text .= ' <a href="'.SpecialPage::getTitleFor(
'UiFeedback' )->getFullURL().'?id='.($id+1).'" >'.wfMessage(
'ui-feedback-special-navi-next' )->text().'</a> | ';
- $output_text .= ' <a href="'.SpecialPage::getTitleFor(
'UiFeedback' )->getFullURL().'?id=-1" >'.wfMessage(
'ui-feedback-special-navi-all' )->text().'</a> ';
+ if($id>1) $output_text .= ' <a href="'.wfAppendQuery(
SpecialPage::getTitleFor( 'UiFeedback' )->getFullURL(), '?id='.($id-1) ).'"
>'.wfMessage( 'ui-feedback-special-navi-previous' )->text().'</a> | ';
+ $output_text .= ' <a href="'.wfAppendQuery(
SpecialPage::getTitleFor( 'UiFeedback' )->getFullURL(), '?id='.($id+1) ).'"
>'.wfMessage( 'ui-feedback-special-navi-next' )->text().'</a> | ';
+ $output_text .= ' <a href="'.wfAppendQuery(
SpecialPage::getTitleFor( 'UiFeedback' )->getFullURL(), '?id=-1' ).'"
>'.wfMessage( 'ui-feedback-special-navi-all' )->text().'</a> ';
$output_text .= '</div>';
/* end page-navi */
}
@@ -250,7 +250,7 @@
\/ \/ */
$output_text .= '<tr>';
/*id*/
- $output_text .= '<td><a href ="'.SpecialPage::getTitleFor(
'UiFeedback' )->getFullURL().'?id='.($row->id).'">'.$row->id.'</a></td>';
+ $output_text .= '<td><a href ="'.wfAppendQuery(
SpecialPage::getTitleFor( 'UiFeedback' )->getFullURL(), 'id='.($row->id)
).'">'.$row->id.'</a></td>';
/*username*/
if($row->username === '') $output_text .=
'<td>'.wfMessage( 'ui-feedback-special-anonymous' )->text().'</td>';
else $output_text .= '<td><a
href="'.Title::makeTitleSafe( NS_USER_TALK, $row->username
)->getFullURL().'">'.$row->username.'</a></td>';
@@ -287,8 +287,8 @@
if($only_one_item)
$output_text .=
'<td>'.htmlspecialchars($row->created).'</td>';
/*type*/
- if($row->type === '1') $output_text .= '<td><a href
="'.SpecialPage::getTitleFor( 'UiFeedback'
)->getFullURL().'?id='.($row->id).'"><div class="icon screenshot-icon"
title="'.wfMessage( 'ui-feedback-special-type-screenshot'
)->text().'">1</div></a></td>';
- else $output_text .= '<td><a href
="'.SpecialPage::getTitleFor( 'UiFeedback'
)->getFullURL().'?id='.($row->id).'"><div class="icon questionnaire-icon"
title="'.wfMessage( 'ui-feedback-special-type-questionnaire'
)->text().'">2</div></a></td>';
+ if($row->type === '1') $output_text .= '<td><a href
="'.wfAppendQuery( SpecialPage::getTitleFor( 'UiFeedback'
)->getFullURL(),'id='.($row->id) ).'"><div class="icon screenshot-icon"
title="'.wfMessage( 'ui-feedback-special-type-screenshot'
)->text().'">1</div></a></td>';
+ else $output_text .= '<td><a href
="'.wfAppendQuery( SpecialPage::getTitleFor( 'UiFeedback'
)->getFullURL(),'id='.($row->id) ).'"><div class="icon questionnaire-icon"
title="'.wfMessage( 'ui-feedback-special-type-questionnaire'
)->text().'">2</div></a></td>';
/*importance*/
if($row->importance == 0) $output_text .=
'<td> </td>';
else $output_text .=
'<td>'.$importance_array[$row->importance].'</td>';
@@ -311,10 +311,10 @@
if($row->status == 0){
$output_text .= '<b>'.wfMessage(
'ui-feedback-special-status-open' )->text().'</b><br/>';
if($can_write) /* only admins can change the status*/
- $output_text .= '<a
href="'.SpecialPage::getTitleFor( 'UiFeedback'
)->getFullURL().'?id='.($row->id).'">'.wfMessage(
'ui-feedback-special-status-in-review' )->text().'</a>';
+ $output_text .= '<a href="'.wfAppendQuery(
SpecialPage::getTitleFor( 'UiFeedback' )->getFullURL(),'id='.($row->id)
).'">'.wfMessage( 'ui-feedback-special-status-in-review' )->text().'</a>';
}else if($row->status == 1){
if($can_write) /* only admins can change the status*/
- $output_text .= '<a
href="'.SpecialPage::getTitleFor( 'UiFeedback'
)->getFullURL().'?id='.($row->id).'"><b>'.wfMessage(
'ui-feedback-special-status-in-review' )->text().'</b></a>';
+ $output_text .= '<a href="'.wfAppendQuery(
SpecialPage::getTitleFor( 'UiFeedback' )->getFullURL(),'id='.($row->id)
).'"><b>'.wfMessage( 'ui-feedback-special-status-in-review'
)->text().'</b></a>';
else
$output_text .= '<b>'.wfMessage(
'ui-feedback-special-status-in-review' )->text().'</b>';
}else if($row->status == 2){
@@ -452,7 +452,7 @@
if($row->type == '1'){
$output_text .= '<div style="clear: both;">';
$output_text .= '<h2>'.wfMessage(
'ui-feedback-special-type-screenshot' )->text().':</h2>';
- $output_text .= '<img
style="max-width:800px;cursor:pointer;" src="'.SpecialPage::getTitleFor(
'UiFeedback_api' )->getFullURL().'?getScreenshotByID='.$row->id.'"
alt="screenshot"
onclick="$(this).css(\'max-width\',\'\').css(\'cursor\',\'auto\');">';
+ $output_text .= '<img
style="max-width:800px;cursor:pointer;" src="'.wfAppendQuery(
SpecialPage::getTitleFor( 'UiFeedback_api' )->getFullURL(),
'getScreenshotByID='.$row->id ).'" alt="screenshot"
onclick="$(this).css(\'max-width\',\'\').css(\'cursor\',\'auto\');">';
$output_text .= '</div>';
}
}
diff --git a/UiFeedback.php b/UiFeedback.php
index 02e23aa..547fb09 100644
--- a/UiFeedback.php
+++ b/UiFeedback.php
@@ -24,9 +24,9 @@
$wgExtensionMessagesFiles['UiFeedback'] = __DIR__ . '/UiFeedback.i18n.php';
// add permissions and groups
-//$wgGroupPermissions['user']['userrights'] = true;
+// $wgGroupPermissions['user']['userrights'] = true;
$wgGroupPermissions['user']['read_uifeedback'] = true;
-//$wgGroupPermissions['*']['read_uifeedback'] = true;
+// $wgGroupPermissions['*']['read_uifeedback'] = true;
$wgGroupPermissions['UIFeedback_Administator']['write_uifeedback'] = true;
// Register modules
--
To view, visit https://gerrit.wikimedia.org/r/53379
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I20c0550c0cb22101bd68529ec1c9e51718f62364
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UIFeedback
Gerrit-Branch: master
Gerrit-Owner: Lbenedix <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
