jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/357603 )

Change subject: BSPageAssignments: Fixed Strict Standard Static function 
BSAssignableBase::getQueryConds() should not be abstract
......................................................................


BSPageAssignments: Fixed Strict Standard Static function 
BSAssignableBase::getQueryConds() should not be abstract

=> Needs cherry-pick to REL1_27

PatchSet4:
* Used an exception instead of an interface, as requested by rvogel

Change-Id: Ic803036239684debaf6efc9e7e7add331a5fe563
---
M PageAssignments/includes/BSAssignableBase.php
1 file changed, 9 insertions(+), 1 deletion(-)

Approvals:
  Robert Vogel: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/PageAssignments/includes/BSAssignableBase.php 
b/PageAssignments/includes/BSAssignableBase.php
index 1a26666..9711560 100644
--- a/PageAssignments/includes/BSAssignableBase.php
+++ b/PageAssignments/includes/BSAssignableBase.php
@@ -134,5 +134,13 @@
                }
        }
 
-       abstract protected static function getQueryConds( $oUser );
+       /**
+        * Gets the class related query condition to get the assignments from
+        * database for a specific user
+        * @param type $oUser
+        * @throws MWException, when not overwritten
+        */
+       protected static function getQueryConds( $oUser ) {
+               throw new MWException( "MIssing method: 
".__CLASS__.":".__METHOD__ );
+       }
 }
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/357603
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic803036239684debaf6efc9e7e7add331a5fe563
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: master
Gerrit-Owner: Pwirth <[email protected]>
Gerrit-Reviewer: Ljonka <[email protected]>
Gerrit-Reviewer: Mglaser <[email protected]>
Gerrit-Reviewer: Pwirth <[email protected]>
Gerrit-Reviewer: Robert Vogel <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to