Alexandros Kosiaris has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/364706 )
Change subject: Fix RSpec for monitoring module
......................................................................
Fix RSpec for monitoring module
Amend to check against the correct entries
Change-Id: I2a8556a71342c1673274ac45efda48892eb965f2
---
M modules/monitoring/spec/defines/monitoring_host_spec.rb
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/06/364706/1
diff --git a/modules/monitoring/spec/defines/monitoring_host_spec.rb
b/modules/monitoring/spec/defines/monitoring_host_spec.rb
index 0d0f3c4..0624e47 100644
--- a/modules/monitoring/spec/defines/monitoring_host_spec.rb
+++ b/modules/monitoring/spec/defines/monitoring_host_spec.rb
@@ -153,7 +153,7 @@
'icon_image' => nil,
'address' => '1.2.3.4'
)
- should_not contain_nagios_host('service.svc.wmnet_mgmt')
+ should_not contain_nagios_host('service.svc.wmnet.mgmt.blabla.wmnet')
end
end
describe 'monitoring a service, with ip_address,parents' do
@@ -170,7 +170,7 @@
'icon_image' => nil,
'address' => '4.3.2.1'
)
- should_not contain_nagios_host('service.svc.wmnet_mgmt')
+ should_not contain_nagios_host('service.svc.wmnet.mgmt.blabla.wmnet')
end
end
describe 'monitoring a service, with fqdn' do
@@ -186,7 +186,7 @@
'icon_image' => nil,
'address' => 'blah.foo.bar'
)
- should_not contain_nagios_host('service.svc.wmnet_mgmt')
+ should_not contain_nagios_host('service.svc.wmnet.mgmt.blabla.wmnet')
end
end
end
--
To view, visit https://gerrit.wikimedia.org/r/364706
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a8556a71342c1673274ac45efda48892eb965f2
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alexandros Kosiaris <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
