jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/364633 )
Change subject: Advise extensions not to modify $wgWhitelistRead ...................................................................... Advise extensions not to modify $wgWhitelistRead Instead they should use the TitleReadWhitelist hook. I've seen this pattern in multiple extensions now, each causing different problems, so it should be explicitly documented. Change-Id: I670b0acde660bdc27a6c7e91c4b1b3baeea8b2e5 --- M includes/DefaultSettings.php 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Addshore: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php index 11f08b2..6ce9a66 100644 --- a/includes/DefaultSettings.php +++ b/includes/DefaultSettings.php @@ -5027,6 +5027,9 @@ * @note Also that this will only protect _pages in the wiki_. Uploaded files * will remain readable. You can use img_auth.php to protect uploaded files, * see https://www.mediawiki.org/wiki/Manual:Image_Authorization + * + * @note Extensions should not modify this, but use the TitleReadWhitelist + * hook instead. */ $wgWhitelistRead = false; -- To view, visit https://gerrit.wikimedia.org/r/364633 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I670b0acde660bdc27a6c7e91c4b1b3baeea8b2e5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Legoktm <[email protected]> Gerrit-Reviewer: Addshore <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
