Pmiazga has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/364846 )
Change subject: Re-enable MediaWiki.Commenting.FunctionComment.MissingReturn
sniff
......................................................................
Re-enable MediaWiki.Commenting.FunctionComment.MissingReturn sniff
Bug: T168384
Change-Id: I8d7b750503ca9c951267a948862c3685ea036100
---
M includes/PopupsContext.php
M phpcs.xml
2 files changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups
refs/changes/46/364846/1
diff --git a/includes/PopupsContext.php b/includes/PopupsContext.php
index f3408b8..da58f29 100644
--- a/includes/PopupsContext.php
+++ b/includes/PopupsContext.php
@@ -148,7 +148,7 @@
/**
* Are Page previews visible on User Preferences Page
*
- * return @bool
+ * @return bool
*/
public function showPreviewsOptInOnPreferencesPage() {
return !$this->isBetaFeatureEnabled()
diff --git a/phpcs.xml b/phpcs.xml
index 26c9398..4a1221a 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -3,7 +3,6 @@
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingReturn" />
<exclude
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
<exclude
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
--
To view, visit https://gerrit.wikimedia.org/r/364846
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d7b750503ca9c951267a948862c3685ea036100
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Pmiazga <pmia...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
