jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/364839 )
Change subject: BlueSpiceVisualEditor: improved context specific availability
of actions
......................................................................
BlueSpiceVisualEditor: improved context specific availability of actions
Table actions were completely removed in menus when no table action
was there. This lead to unexpected states for users.
Change-Id: I2fab0ee66b05bb4f14f110993bdd9202dc5d43a1
---
M VisualEditor/resources/tiny_mce_plugins/bsactions/plugin.js
1 file changed, 0 insertions(+), 27 deletions(-)
Approvals:
Robert Vogel: Looks good to me, approved
jenkins-bot: Verified
diff --git a/VisualEditor/resources/tiny_mce_plugins/bsactions/plugin.js
b/VisualEditor/resources/tiny_mce_plugins/bsactions/plugin.js
index 667feb7..777fb4d 100644
--- a/VisualEditor/resources/tiny_mce_plugins/bsactions/plugin.js
+++ b/VisualEditor/resources/tiny_mce_plugins/bsactions/plugin.js
@@ -25,23 +25,6 @@
_editor,
_currentImagePath;
- function handleDisabledState(ctrl, selector) {
- var editor = tinyMCE.activeEditor;
- function bindStateListener() {
-
ctrl.disabled(!editor.dom.getParent(editor.selection.getStart(), selector));
-
- editor.selection.selectorChanged(selector,
function(state) {
- ctrl.disabled(!state);
- });
- }
-
- if (editor.initialized) {
- bindStateListener();
- } else {
- editor.on('init', bindStateListener);
- }
- }
-
function handleVisibilityState(ctrl, selector) {
var editor = tinyMCE.activeEditor;
function bindStateListener() {
@@ -71,11 +54,6 @@
} else {
editor.on('init', bindStateListener);
}
- }
-
- function postRender() {
- /*jshint validthis:true*/
- handleDisabledState(this, 'table');
}
function postRenderVisibilityTable() {
@@ -115,11 +93,6 @@
if($(tinyMCE.activeEditor.getElement()).data("text-changed")){
tinyMCE.activeEditor.isNotDirty = false;
}
- }
-
- function postRenderCell() {
- /*jshint validthis:true*/
- handleDisabledState(this, 'td,th');
}
function _doSaveArticle() {
--
To view, visit https://gerrit.wikimedia.org/r/364839
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2fab0ee66b05bb4f14f110993bdd9202dc5d43a1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: master
Gerrit-Owner: Mglaser <[email protected]>
Gerrit-Reviewer: Robert Vogel <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
