Aleksey Bekh-Ivanov (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/365026 )
Change subject: Move TODO to proper place
......................................................................
Move TODO to proper place
Change-Id: I33598873e7f5c5908fc36fbd0cd1c80a301b29a7
---
M src/Content/LexemeContent.php
M src/DemoData/DefaultPopulator.php
2 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseLexeme
refs/changes/26/365026/1
diff --git a/src/Content/LexemeContent.php b/src/Content/LexemeContent.php
index 64d702b..7c0430d 100644
--- a/src/Content/LexemeContent.php
+++ b/src/Content/LexemeContent.php
@@ -54,6 +54,7 @@
/** @var Lexeme $lexeme */
$lexeme = $this->lexemeHolder->getEntity( Lexeme::class );
+ // TODO: This is a test dummy that must be removed later
if ( $lexeme->getId()->getSerialization() ===
DemoData\Id::L_HARD ) {
( new DemoData\HardLexemePopulator() )->populate(
$lexeme );
} else {
diff --git a/src/DemoData/DefaultPopulator.php
b/src/DemoData/DefaultPopulator.php
index faf2d96..408bc53 100644
--- a/src/DemoData/DefaultPopulator.php
+++ b/src/DemoData/DefaultPopulator.php
@@ -21,7 +21,6 @@
class DefaultPopulator {
public function populate( Lexeme $lexeme ) {
- // TODO: This obviously is a dummy that must be removed
$grammaticalFeatures1 = [ new ItemId( 'Q2' ) ];
$grammaticalFeatures2 = [ new ItemId( 'Q2' ), new ItemId( 'Q3'
) ];
$statements1 = new StatementList(
--
To view, visit https://gerrit.wikimedia.org/r/365026
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I33598873e7f5c5908fc36fbd0cd1c80a301b29a7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: Aleksey Bekh-Ivanov (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
