jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/364760 )
Change subject: DesktopArticleTarget.init: only show welcome dialog if page
editable
......................................................................
DesktopArticleTarget.init: only show welcome dialog if page editable
"Welcome to wikipedia, anyone can edit, we welcome all improvements. Start
editing!" is a bit out of place when what you'll see after clicking "start
editing" is "you can't edit this page".
Bug: T138715
Change-Id: I9f655a5f12d4e45644bd01631c2d3131375d8e8f
---
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
index 2452098..5d338b7 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
@@ -1043,6 +1043,7 @@
welcomeDialogLocalStorageValue = localStorage.getItem(
've-beta-welcome-dialog' );
} catch ( e ) {}
if (
+ pageCanLoadEditor &&
showWikitextWelcome &&
mw.config.get( 'wgVisualEditorConfig' ).showBetaWelcome
&&
[ 'edit', 'submit' ].indexOf( mw.config.get( 'wgAction'
) ) !== -1 &&
--
To view, visit https://gerrit.wikimedia.org/r/364760
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f655a5f12d4e45644bd01631c2d3131375d8e8f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: DLynch <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
