Nschaaf has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365211 )

Change subject: Fix split call
......................................................................

Fix split call

Change-Id: I8e74740e7ca8cc4506b2f927f7e00d4f320b6c6a
---
M lib/translation.js
M routes/translation.js
2 files changed, 2 insertions(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/services/recommendation-api 
refs/changes/11/365211/1

diff --git a/lib/translation.js b/lib/translation.js
index 87abf2c..0e5a2ef 100644
--- a/lib/translation.js
+++ b/lib/translation.js
@@ -210,7 +210,6 @@
                        ?article schema:isPartOf 
<https://${target}.wikipedia.org/> .
                      }
                    } GROUP BY ?item`;
-
     return wdqsApiGet(app, query)
     .then((response) => {
         return response.body.results.bindings.map((item) => {
diff --git a/routes/translation.js b/routes/translation.js
index 158c6fd..191bed9 100644
--- a/routes/translation.js
+++ b/routes/translation.js
@@ -46,7 +46,7 @@
  * Gets the articles existing in source but missing in domain.
  */
 router.get('/articles/:source', (req, res) => {
-    const target = req.params.domain.split('.', 0);
+    const target = req.params.domain.split('.')[0];
     return recommend(req, res, req.params.source, target);
 });
 
@@ -56,7 +56,7 @@
  * Gets the articles existing in source but missing in domain based on seed.
  */
 router.get('/articles/:source/:seed', (req, res) => {
-    const target = req.params.domain.split('.', 0);
+    const target = req.params.domain.split('.')[0];
     return recommend(req, res, req.params.source, target, req.params.seed);
 });
 

-- 
To view, visit https://gerrit.wikimedia.org/r/365211
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e74740e7ca8cc4506b2f927f7e00d4f320b6c6a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/recommendation-api
Gerrit-Branch: master
Gerrit-Owner: Nschaaf <nsch...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to