jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/364929 )
Change subject: Puppet: Downgrade npm to version 2
......................................................................
Puppet: Downgrade npm to version 2
After we've upgraded node.js in Vagrant to version 6,
it brought us npm version 3. However, version 3 has a
weird bug that doesn't allow properly installing dependencies
with --no-bin-links.
I couldn't find a workaround for the bug or any reference that
it's been addressed in version 3, so let's stick with version 2
for now.
Also, we don't need nodejs-legacy ane more or older legacy npm
to be installed, so deleted puppet that used to install them.
Bug: T162468
Change-Id: I0c9c2573c0b2163976f8541fa86637f8a99149d4
---
M puppet/modules/npm/manifests/init.pp
1 file changed, 11 insertions(+), 14 deletions(-)
Approvals:
Mobrovac: Looks good to me, approved
jenkins-bot: Verified
diff --git a/puppet/modules/npm/manifests/init.pp
b/puppet/modules/npm/manifests/init.pp
index ef02ea8..dde3fdd 100644
--- a/puppet/modules/npm/manifests/init.pp
+++ b/puppet/modules/npm/manifests/init.pp
@@ -26,20 +26,6 @@
priority => 1010,
}
- # Install the npm and nodejs-legacy packages manually
- # before the nodesource repo has been added so as not to
- # conflict for package versions
- exec { 'ins-npm-nodejs-legacy':
- command => '/usr/bin/apt-get update && /usr/bin/apt-get install -y
--force-yes npm nodejs-legacy',
- environment => 'DEBIAN_FRONTEND=noninteractive',
- unless => '/usr/bin/dpkg -l npm && /usr/bin/dpkg -l
nodejs-legacy',
- user => 'root',
- before => [
- Apt::Repository['nodesource'],
- Apt::Pin['nodejs'],
- ],
- }
-
package { 'nodejs':
ensure => latest,
require => [
@@ -55,6 +41,17 @@
group => 'root',
}
+ # Node 6 brings in npm 3 that doesn't work in shared folders due to a bug.
+ # See: https://github.com/npm/npm/issues/9953
+ # Although the ticket is closed, the issue is still present, so downgrade
to npm 2
+ exec { 'downgrade_npm':
+ command => '/usr/bin/npm install -g npm@latest-2',
+ user => 'root',
+ require => [
+ Package['nodejs'],
+ ],
+ }
+
env::var { 'NPM_CONFIG_CACHE':
value => $cache_dir,
require => Exec['npm_set_cache_dir'],
--
To view, visit https://gerrit.wikimedia.org/r/364929
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c9c2573c0b2163976f8541fa86637f8a99149d4
Gerrit-PatchSet: 7
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Ppchelko <ppche...@wikimedia.org>
Gerrit-Reviewer: BryanDavis <bda...@wikimedia.org>
Gerrit-Reviewer: Dduvall <dduv...@wikimedia.org>
Gerrit-Reviewer: GWicke <gwi...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Mobrovac <mobro...@wikimedia.org>
Gerrit-Reviewer: Ppchelko <ppche...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
