jenkins-bot has submitted this change and it was merged.
Change subject: Fix JSDuck warnings
......................................................................
Fix JSDuck warnings
Change-Id: Ibc3f49c55ded5490fcb071f0ccf9f25a71a06c97
Warning: categories.json Class 've.NodeFactory' not found in categories file
Warning: ve.ui.ContentDialog.js:8: Unknown type ve.ui.Surface
Warning: ve.ui.MetaDialog.js:8: Unknown type ve.ui.Surface
Warning: ve.ui.Dialog.js:8: Unknown type ve.ui.Surface
---
M .docs/categories.json
M modules/ve/ui/dialogs/ve.ui.ContentDialog.js
M modules/ve/ui/dialogs/ve.ui.MetaDialog.js
M modules/ve/ui/ve.ui.Dialog.js
4 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.docs/categories.json b/.docs/categories.json
index fd3d78e..6900e4f 100644
--- a/.docs/categories.json
+++ b/.docs/categories.json
@@ -106,7 +106,7 @@
},
{
"name": "Factories",
- "classes": ["ve.ActionFactory"]
+ "classes": ["ve.ActionFactory",
"ve.NodeFactory"]
},
{
"name": "Nodes",
diff --git a/modules/ve/ui/dialogs/ve.ui.ContentDialog.js
b/modules/ve/ui/dialogs/ve.ui.ContentDialog.js
index 2ded73d..3bf8a95 100644
--- a/modules/ve/ui/dialogs/ve.ui.ContentDialog.js
+++ b/modules/ve/ui/dialogs/ve.ui.ContentDialog.js
@@ -13,7 +13,7 @@
* @extends ve.ui.Dialog
*
* @constructor
- * @param {ve.ui.Surface} surface
+ * @param {ve.Surface} surface
*/
ve.ui.ContentDialog = function VeUiContentDialog( surface ) {
// Parent constructor
diff --git a/modules/ve/ui/dialogs/ve.ui.MetaDialog.js
b/modules/ve/ui/dialogs/ve.ui.MetaDialog.js
index 8312288..dc45e77 100644
--- a/modules/ve/ui/dialogs/ve.ui.MetaDialog.js
+++ b/modules/ve/ui/dialogs/ve.ui.MetaDialog.js
@@ -13,7 +13,7 @@
* @extends ve.ui.Dialog
*
* @constructor
- * @param {ve.ui.Surface} surface
+ * @param {ve.Surface} surface
*/
ve.ui.MetaDialog = function VeUiMetaDialog( surface ) {
// Parent constructor
diff --git a/modules/ve/ui/ve.ui.Dialog.js b/modules/ve/ui/ve.ui.Dialog.js
index faf881a..005a670 100644
--- a/modules/ve/ui/ve.ui.Dialog.js
+++ b/modules/ve/ui/ve.ui.Dialog.js
@@ -12,7 +12,7 @@
* @abstract
*
* @constructor
- * @param {ve.ui.Surface} surface
+ * @param {ve.Surface} surface
*/
ve.ui.Dialog = function VeUiDialog( surface ) {
// Parent constructor
--
To view, visit https://gerrit.wikimedia.org/r/53461
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc3f49c55ded5490fcb071f0ccf9f25a71a06c97
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Trevor Parscal <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
