Giuseppe Lavagetto has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/365570 )
Change subject: rsyslog::conf: validate priority with validate_numeric
......................................................................
rsyslog::conf: validate priority with validate_numeric
Change-Id: I374060afc7fb7830a2de999a1f4874a3441fe986
---
M modules/rsyslog/manifests/conf.pp
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/70/365570/1
diff --git a/modules/rsyslog/manifests/conf.pp
b/modules/rsyslog/manifests/conf.pp
index 6f5f7c6..9d66275 100644
--- a/modules/rsyslog/manifests/conf.pp
+++ b/modules/rsyslog/manifests/conf.pp
@@ -34,9 +34,8 @@
) {
include ::rsyslog
- if $priority !~ /^\d?\d$/ {
- fail("'priority' must be an integer between 0 - 99 (got:
${priority}).")
- }
+ # TODO/puppet4 make this a parameter type check
+ validate_numeric($priority, 99, 0)
$basename = regsubst($title, '[\W_]', '-', 'G')
$filename = sprintf('/etc/rsyslog.d/%02d-%s.conf', $priority, $basename)
--
To view, visit https://gerrit.wikimedia.org/r/365570
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I374060afc7fb7830a2de999a1f4874a3441fe986
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Giuseppe Lavagetto <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
