Bartosz Dziewoński has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/365657 )
Change subject: rcfilters: LiveUpdateButtonWidget: Fix bad method call leading
to weird warning
......................................................................
rcfilters: LiveUpdateButtonWidget: Fix bad method call leading to weird warning
When viewing recent changes, I get 'JQMIGRATE: jQuery.unique is
deprecated, use jQuery.uniqueSort' in the console.
The bad parentheses change the meaning of $.extend to try to extend
the global $ object, and somehow that ends up touching deprecated
properties. There might be a jQuery bug here somewhere too.
Change-Id: I49265c5882dd189e2b17916c2e14c62d16235677
---
M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.LiveUpdateButtonWidget.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/57/365657/1
diff --git
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.LiveUpdateButtonWidget.js
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.LiveUpdateButtonWidget.js
index 8bab981..90ee4d7 100644
---
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.LiveUpdateButtonWidget.js
+++
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.LiveUpdateButtonWidget.js
@@ -15,7 +15,7 @@
mw.rcfilters.ui.LiveUpdateButtonWidget.parent.call( this,
$.extend( {
icon: 'play',
label: mw.message( 'rcfilters-liveupdates-button'
).text()
- } ), config );
+ }, config ) );
this.controller = controller;
--
To view, visit https://gerrit.wikimedia.org/r/365657
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I49265c5882dd189e2b17916c2e14c62d16235677
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
