MtMNC has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/365664 )
Change subject: Move indicators to be consistent with other skins
......................................................................
Move indicators to be consistent with other skins
Moves the indicators above firstHeading to be consistent with
other skins such as Vector. CSS is changed as appropriate. This
improves the indicators' behavior when they or firstHeading are
very large. Instead of rendering behind firstHeading as was the
case before, now the indicators force firstHeading to wrap to
multiple lines.
Change-Id: I551ce2c3ae5447297333f1c505a4f5bfcf250dda
---
M Refreshed.skin.php
M refreshed/styles/screen/main.css
M skin.json
3 files changed, 10 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Refreshed
refs/changes/64/365664/1
diff --git a/Refreshed.skin.php b/Refreshed.skin.php
old mode 100644
new mode 100755
index 8bd623c..1ca64de
--- a/Refreshed.skin.php
+++ b/Refreshed.skin.php
@@ -469,6 +469,11 @@
<main id="content">
<article>
<header id="content-heading">
+ <?php
+ if ( method_exists( $this,
'getIndicators' ) ) {
+ echo
$this->getIndicators();
+ }
+ ?>
<h1 id="firstHeading"
class="scroll-shadow"><?php $this->html( 'title' ) ?></h1>
<div id="main-title-messages">
<div id="siteSub"><?php
$this->msg( 'tagline' ) ?></div>
@@ -480,11 +485,6 @@
}
?>
</div>
- <?php
- if ( method_exists( $this,
'getIndicators' ) ) {
- echo
$this->getIndicators();
- }
- ?>
<div class="standard-toolbox
static-toolbox" role="menubar">
<?php
$lastLinkOutsideOfStandardToolboxDropdownHasBeenGenerated = false;
diff --git a/refreshed/styles/screen/main.css b/refreshed/styles/screen/main.css
old mode 100644
new mode 100755
index e9f8ed2..851867c
--- a/refreshed/styles/screen/main.css
+++ b/refreshed/styles/screen/main.css
@@ -307,23 +307,22 @@
}
#content-heading {
- padding: 0 0.9em; /* 1em (#bodyContent padding-left) * 0.9em
(#bodyContent font-size) */
- padding-bottom: 2.5em; /* 0.25em (padding on top of .standard-toolbox)
+ 1.5em (height of .standard-toolbox) + 0.75em (padding on bottom of
.standard-toolbox) */
+ /* padding-bottom: 1em (#bodyContent padding-left) * 0.9em
(#bodyContent font-size);
+ padding-left: 0.25em (padding on top of .standard-toolbox) + 1.5em
(height of .standard-toolbox) + 0.75em (padding on bottom of .standard-toolbox)
*/
+ padding: 0.5em 0 0.9em 2.5em;
position: relative;
}
#firstHeading {
font-size: 2.68em;
font-family: "Lato Body", sans-serif;
- padding-top: 0.2em;
- padding-bottom: 0;
+ padding: 0;
margin-bottom: 0;
border: 0;
}
.mw-indicators {
float: right;
- margin-top: -1.5em;
}
.mw-indicator {
diff --git a/skin.json b/skin.json
old mode 100644
new mode 100755
index 77b13e3..0feae23
--- a/skin.json
+++ b/skin.json
@@ -1,6 +1,6 @@
{
"name": "Refreshed",
- "version": "3.3.0",
+ "version": "3.3.1",
"author": [
"Adam Carter",
"Drew1200",
--
To view, visit https://gerrit.wikimedia.org/r/365664
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I551ce2c3ae5447297333f1c505a4f5bfcf250dda
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Refreshed
Gerrit-Branch: master
Gerrit-Owner: MtMNC <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
